Skip to content

Update sangria-marshalling-api to 1.1.2#1139

Closed
scala-steward wants to merge 3 commits into
sangria-graphql:mainfrom
scala-steward:update/sangria-marshalling-api-1.1.2
Closed

Update sangria-marshalling-api to 1.1.2#1139
scala-steward wants to merge 3 commits into
sangria-graphql:mainfrom
scala-steward:update/sangria-marshalling-api-1.1.2

Conversation

@scala-steward

Copy link
Copy Markdown
Contributor

About this PR

📦 Updates org.sangria-graphql:sangria-marshalling-api from 1.0.8 to 1.1.2

📜 GitHub Release Notes - Version Diff

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.sangria-graphql", artifactId = "sangria-marshalling-api" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.sangria-graphql", artifactId = "sangria-marshalling-api" }
}]
labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

@yanns

yanns commented Sep 29, 2024

Copy link
Copy Markdown
Contributor
[error] /home/runner/work/sangria/sangria/modules/core/src/main/scala/sangria/execution/ResultResolver.scala:157:34: missing argument list for method createLocation in class ResultResolver
[error] Unapplied methods are only converted to functions when a function type is expected.
[error] You can make this conversion explicit by writing `createLocation _` or `createLocation(_)` instead of `createLocation`.
[error]     marshaller.mapAndMarshal(px, createLocation)
[error]         

@yanns

yanns commented Oct 28, 2024

Copy link
Copy Markdown
Contributor

scala 3 does not like that there are 2 possible implicits.

[error] -- [E172] Type Error: /Users/yannsimon/projects/sangria-graphql/sangria/modules/core/src/test/scala/sangria/execution/ScalarAliasSpec.scala:70:93 
[error] 70 |    Argument("cid", OptionInputType(ListInputType(ListInputType(OptionInputType(UUIDType)))))
[error]    |                                                                                             ^
[error]    |Ambiguous given instances: both method iterableInput in object FromInput and method seqInput in object FromInput match type sangria.marshalling.FromInput[T] of parameter fromInput of method apply in object Argument

@scala-steward

Copy link
Copy Markdown
Contributor Author

Superseded by #1150.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants