removed coop and intern from role names#464
Open
gpalmer27 wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Collaborator
Author
|
@songmichael11 just adding this comment so i don't forget, before / right after this is merged, one of us should run the script on staging + prod db |
Collaborator
There was a problem hiding this comment.
so like should devs just run pnpm db:strip-role-keywords then? does this apply the changes cause wouldn't you need the --apply instead of just pnpm with-env tsx src/scripts/strip-role-keywords.ts
Collaborator
Author
There was a problem hiding this comment.
pnpm strip-role-keywords --apply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
see title
created a script that devs can run in their local environments and that we can run in prod + staging to delete the existing bad entries
added a check so people can no longer add 'coop' or 'intern' or variants of that
Motivation and Context
Closes #455
How has this been tested?
my eyes
Screenshots (if appropriate):
Types of changes
pnpm db:generateand verified generated SQL migration files inpackages/db/drizzleChecklist: