add new view modal fields#460
Open
songmichael11 wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
gpalmer27
reviewed
Jun 21, 2026
Collaborator
There was a problem hiding this comment.
what i found while testing this:
- the job length field on the form isn't required but it has a red asterisk next to it, we should make it required (and make sure all other fields with a star are required)
- the interview rounds field is required but there's no star next to it, we should add that star
(sorry ik these aren't related to your changes lol but i feel like it goes well with this ticket)
Job length had a required asterisk but was optional; make it required. Work hours and hourly pay were in the same state, so make them required too. Hourly pay accepts "0" so the Unpaid toggle still satisfies it. Add the missing asterisks to the required interview round Type and Difficulty fields. Apply the same changes to the view/edit modal. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
is this supposed to show the logo (i'm too lazy to check figma)
|
Collaborator
|
There are some discrepancies between the field names in the review form vs. what's in the popup:
Also other note: when filling out the review form, for the interview section, should it default to only having one round? i feel like it's a bit weird to default to having two required rounds, but also open to discussion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated view review modal.
Motivation and Context
Closes #453
How has this been tested?
Looked at it.
Screenshots (if appropriate):
Types of changes
pnpm db:generateand verified generated SQL migration files inpackages/db/drizzleChecklist: