Make derivatives configurable#7541
Open
kirkkwang wants to merge 2 commits into
Open
Conversation
Test Results 17 files ± 0 17 suites ±0 3h 33m 33s ⏱️ + 3m 54s Results for commit affdba6. ± Comparison against base commit 5cc41d6. This pull request removes 440 and adds 451 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
kirkkwang
force-pushed
the
configurable-file-set-derivatives
branch
2 times, most recently
from
July 15, 2026 20:44
e3f4732 to
92642f4
Compare
kirkkwang
marked this pull request as draft
July 15, 2026 21:48
This commit introduces a new configuration option so it will make it easier for consuming applications to override default derivative settings.
kirkkwang
force-pushed
the
configurable-file-set-derivatives
branch
from
July 16, 2026 17:18
92642f4 to
db3b950
Compare
kirkkwang
marked this pull request as ready for review
July 16, 2026 19:50
Contributor
|
I know I can't approve this because Kirk and I are from the same organization, but I think it's a fantastic idea. Anything making Hyrax configurable so we can have less overrides is great. |
kirkkwang
force-pushed
the
configurable-file-set-derivatives
branch
from
July 17, 2026 15:10
942d8d4 to
db3b950
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new configuration option so it will make it easier for consuming applications to override default derivative settings.