Skip to content

Make derivatives configurable#7541

Open
kirkkwang wants to merge 2 commits into
mainfrom
configurable-file-set-derivatives
Open

Make derivatives configurable#7541
kirkkwang wants to merge 2 commits into
mainfrom
configurable-file-set-derivatives

Conversation

@kirkkwang

Copy link
Copy Markdown
Contributor

This commit introduces a new configuration option so it will make it easier for consuming applications to override default derivative settings.

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown

Test Results

    17 files  ± 0      17 suites  ±0   3h 33m 33s ⏱️ + 3m 54s
 7 988 tests +11   7 681 ✅ +11  307 💤 ±0  0 ❌ ±0 
27 315 runs  +40  26 716 ✅ +40  599 💤 ±0  0 ❌ ±0 

Results for commit affdba6. ± Comparison against base commit 5cc41d6.

This pull request removes 440 and adds 451 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f37d68cb2d8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f4a43d1c448>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fdf34ed9d90>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fee6c78aa20>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f37d68c0b58>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f4a4ae00010>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fdf45ad4c48>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fee7038e120>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 2132c8ed-856c-4771-994f-282c496d9150
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 497eb04a-2b61-4268-a741-91b1fe06e111
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f358f107450>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f3f9e16a280>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fac2eedca88>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fcf9dde4120>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f35965abb80>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f3fa1c52320>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fac2efe6f50>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fcf9da69888>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 4b0488cc-5e70-4eb2-aac6-cd0906a3d8ae
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 304717d3-108b-4d96-89a1-35e21b9216a2
…

♻️ This comment has been updated with latest results.

@kirkkwang
kirkkwang force-pushed the configurable-file-set-derivatives branch 2 times, most recently from e3f4732 to 92642f4 Compare July 15, 2026 20:44
@kirkkwang
kirkkwang marked this pull request as draft July 15, 2026 21:48
This commit introduces a new configuration option so it will make it
easier for consuming applications to override default derivative
settings.
@kirkkwang
kirkkwang force-pushed the configurable-file-set-derivatives branch from 92642f4 to db3b950 Compare July 16, 2026 17:18
@kirkkwang
kirkkwang marked this pull request as ready for review July 16, 2026 19:50
@laritakr

Copy link
Copy Markdown
Contributor

I know I can't approve this because Kirk and I are from the same organization, but I think it's a fantastic idea. Anything making Hyrax configurable so we can have less overrides is great.

@kirkkwang
kirkkwang force-pushed the configurable-file-set-derivatives branch from 942d8d4 to db3b950 Compare July 17, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants