Additional low-rank decomposition methods (by Matt, on top of a few uncommitted updates on my side)#70
Open
steo85it wants to merge 66 commits into
Open
Additional low-rank decomposition methods (by Matt, on top of a few uncommitted updates on my side)#70steo85it wants to merge 66 commits into
steo85it wants to merge 66 commits into
Conversation
Collaborator
Author
|
superseeds #68 |
steo85it
changed the title
Collaborator
Author
|
@sampotter should we just accept these and merge? ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As from the title, we merged our updates (mine and Matt's internship's code and examples), then checked that Matt's examples still work properly.
Please have a look and if ok, feel free to merge (never sure whether to keep all commits or squash them... easier to rollback with the latter, but one loses a bit of info).
@mrepasky3