Feat/2.0#16
Open
samadritsarkar2 wants to merge 6 commits into
Open
Conversation
…tubeDL for on-device audio downloads
samadritsarkar2
force-pushed
the
feat/2.0
branch
from
b98906f to
214dfe5
Compare
… refactor Sprint 0-HOTFIX — Runtime Crash Fixes: - Fix undefined setError in SavedPlaylists.js - Add missing PermissionsAndroid import in utils/index.js - Add missing Alert import in DownloadingHelper.js Sprint 0 — Repo Hygiene & Secrets: - Remove hardcoded secrets from build.gradle - Fix .gitignore, add .env configuration - Remove orphaned dependencies (react-scripts, spinkit, react-native-slider) Sprint 1 — Performance & Memory Leaks: - Migrate ScrollView → FlatList in 6 components - Fix memory leaks: Library.js listeners + setTimeout cleanups - Add babel-plugin-transform-remove-console for production - Add React.memo and useCallback memoization Sprint 2 — Architecture & Code Quality: - Redux refactor: rename PlaylistReducer export, create selectors.js - Extract hooks: usePlaylist, useDownloads, useDownloadedTracks - Fix AsyncStorage race conditions with new utils/storage.js - Fix broken imports: @rneui/themed removal, add missing Spinner/TextTicker UI/Theme Refactor: - Add centralized theme.js (colors, fonts, spacing, radii, commonStyles) - Create shared components (BottomSheetModal, LoadingScreen, TrackRow, etc.) - Apply theme tokens across all components - Modernize navigation styling
samadritsarkar2
force-pushed
the
feat/2.0
branch
from
214dfe5 to
f641873
Compare
Parallax cover image with overscroll zoom and darkening overlay, animated nav bar that fades in as metadata scrolls behind it, and inline shuffle/play controls. All animations driven by Reanimated v3 worklets on the UI thread. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Overscroll zoom never works on Android (scroll offset never goes negative). Removed scale interpolation, kept parallax drift. Also: extracted require() to module constants, stabilized ItemSeparator/ListFooter, wrapped onLayout in useCallback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Unified DownloadedTracksView and Playlist into thin wrappers around a shared CollapsibleTrackList that handles the parallax header, animated nav bar, gradient, and FlatList scaffolding. - Playlist.js migrated to TrackRow + BottomSheetModal - Memo'd track item components with FadeInDown limited to first 10 - Duplicate styles (trackItemBg, controlsRow, moreButton, moreIcon) moved to commonStyles in theme.js - Stabilized onGoBack with useCallback, onMetadataLayout with guard - CollapsibleTrackList wrapped in React.memo Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.