Bound slave timeout killing#67
Open
salva wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #38 by preventing Net::OpenSSH::_waitpid from potentially waiting forever after a slave operation times out and the child ignores TERM, by introducing a bounded signal escalation sequence.
Changes:
- Add a slave-specific kill escalation schedule (
TERM→KILL). - Rate-limit kill attempts to once per second and stop retrying after the existing “>20 attempts” limit.
- Preserve the existing timeout error reporting (
OSSH_SLAVE_TIMEOUT).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
701
to
+702
| my @kill_signal = qw(0 0 TERM TERM TERM KILL); | ||
| my @slave_kill_signal = qw(TERM TERM TERM KILL); |
| kill $sig => $pid; | ||
| } | ||
| $self->_or_set_error(OSSH_SLAVE_TIMEOUT, "ssh slave failed", "timed out"); | ||
| return undef if $kill_count > 20; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent
_waitpidfrom waiting indefinitely after a slave process times out.Changes
TERMinitially, escalate toKILL, and stop retrying after the existing 20-attempt style limit.Fixes #38.
Testing
perl -Ilib -c lib/Net/OpenSSH.pmperl -Ilib t/1_run.t