Handle _io3 syscall return states#64
Open
salva wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the internal _io3 I/O loop in Net::OpenSSH to correctly distinguish EOF/zero-byte successful returns from errno-bearing syscall failures, avoiding retries driven by stale $!.
Changes:
- Treat
sysread(...) == 0as EOF (close/disable the relevant output handle) without consulting$!. - Consult
$!forsysreadonly when the return value isundef(error case). - Consult
$!forsyswriteonly when the return value isundef(error case).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| $read and $debug & 128 and _hexdump substr $bout, $offset; | ||
| } | ||
| unless ($read or grep $! == $_, @retriable) { | ||
| unless (defined($read) ? $read : grep $! == $_, @retriable) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
_io3distinguish zero-byte successful returns from errno-bearing syscall failures.Changes
sysreadreturning0as EOF without consulting stale$!.$!forsysreadonly when the return value isundef.$!forsyswriteonly when the return value isundef.Fixes #39.
Fixes #40.
Testing
perl -Ilib -c lib/Net/OpenSSH.pmperl -Ilib t/1_run.t