Repository navigation
Conversation
The aiohttp main loop must emit latency metrics for skill requests.
process_message already sampled the load/save stages, but script time was
never sampled here (sampling_script_time was only called from the Kafka
loop) and there was no total request timer.
- monitoring: add sampling_total_time() -> {app}_total_time histogram.
- main_loop_async_http: sample script time around
model.answer/_generate_answers; wrap the whole processing
(load -> script -> save -> postprocess) in a total timer and sample it;
add "Total time" to the "timings" log record.
- Kept the existing {app}_load_time/{app}_save_time names instead of the
task's {app}_loading_time/{app}_saving_time: same stages, renaming would
break existing dashboards (agreed with the task owner).
Verified in Docker on general_base_cloud: after 4 real MESSAGE_TO_SKILL
mocks, /metrics shows general_base_{load,script,save,total}_time count=4,
total ~= load+script+save.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aiohttp main loop must emit latency metrics for skill requests. process_message already sampled the load/save stages, but script time was never sampled here (sampling_script_time was only called from the Kafka loop) and there was no total request timer.
Verified in Docker on general_base_cloud: after 4 real MESSAGE_TO_SKILL mocks, /metrics shows general_base_{load,script,save,total}_time count=4, total ~= load+script+save.