Skip to content

fix: prevent command injection in nightly workflow @W-24289114@ #2938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iowillhoit merged 4 commits into from
Sep 24, 2026
Merged

fix: prevent command injection in nightly workflow @W-24289114@ #2938

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a842d79
fix: prevent command injection in nightly workflow @W-24289114@
WillieRuemmele Sep 24, 2026
dcec65f
chore: add comments explaining intentional word-splitting
WillieRuemmele Sep 24, 2026
2d00c84
Merge branch 'main' into wr/fixNightlyWorkflowInjection
WillieRuemmele Sep 24, 2026
9447729
fix: remove ~ from input validation allowlist
WillieRuemmele Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions .github/workflows/make-pr-for-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,15 +89,29 @@ jobs:
- name: Fetch all branches
run: git fetch

# --only input using a "ternary-ish": https://github.com/actions/runner/issues/409#issuecomment-752775072
# ${{ x && 'ifTrue' || 'ifFalse' }}
- name: Validate inputs
if: ${{ inputs.only != '' }}
shell: bash
run: |
if [[ ! "$INPUT_ONLY" =~ ^[@a-zA-Z0-9/_,.-]+$ ]]; then
echo "::error::'only' input contains invalid characters. Must be a comma-separated list of package names."
exit 1
fi
env:
INPUT_ONLY: ${{ inputs.only }}

- name: Build nightly PR (minor)
run: sf-release cli:release:build --start-from-github-ref main ${{ inputs.only && format('--only {0}', inputs.only) || '' }} --label nightly-automerge --release-channel nightly
# $ONLY_FLAG is intentionally unquoted — it must word-split into two args (--only <value>)
run: sf-release cli:release:build --start-from-github-ref main $ONLY_FLAG --label nightly-automerge --release-channel nightly
env:
ONLY_FLAG: ${{ inputs.only && format('--only {0}', inputs.only) || '' }}
# If the package.json 'minor' IS EQUAL TO the latest-rc 'minor', we want to bump 'minor'
if: ${{ fromJSON(steps.package-json-semver-info.outputs.minor) == fromJSON(steps.latest-rc-semver-info.outputs.minor) }}

- name: Build nightly PR (patch)
run: sf-release cli:release:build --start-from-github-ref main --patch ${{ inputs.only && format('--only {0}', inputs.only) || '' }} --label nightly-automerge --release-channel nightly
# $ONLY_FLAG is intentionally unquoted — it must word-split into two args (--only <value>)
run: sf-release cli:release:build --start-from-github-ref main --patch $ONLY_FLAG --label nightly-automerge --release-channel nightly
env:
ONLY_FLAG: ${{ inputs.only && format('--only {0}', inputs.only) || '' }}
# If the package.json 'minor' IS GREATER THAN the latest-rc 'minor', we want to bump 'patch'
if: ${{ fromJSON(steps.package-json-semver-info.outputs.minor) > fromJSON(steps.latest-rc-semver-info.outputs.minor) }}
Loading