feat(messages): route messages through Queue Service and drop vestigi…#3223
Draft
PooyaRaki wants to merge 1 commit into
Draft
feat(messages): route messages through Queue Service and drop vestigi…#3223PooyaRaki wants to merge 1 commit into
PooyaRaki wants to merge 1 commit into
Conversation
…al safeAppId When FF_QUEUE_SERVICE is enabled, MessagesRepository serves message reads/writes from the Queue Service (with cross-chain filtering); otherwise it uses the Transaction Service. Drops the now-vestigial safeAppId from the create-message path, keeping the DTO field as a deprecated no-op. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Route messages through the Queue Service when
FF_QUEUE_SERVICEis enabled (default off → behavior unchanged), and drop the vestigialsafeAppIdfrom message creation. Part 6/6 of thefeat/migrateToQueueServicesplit; top of the stack, merge last.Changes
MessagesRepository: when the flag is on, serve message reads/writes from the Queue Service with cross-chain filtering; otherwise use the Transaction Service.QueueServiceModuleintoMessagesModule.safeAppIdfrom the create-message path (interface, service, repository); keep theCreateMessageDtofield as a deprecated no-op.