refactor: remove Zerion as a balances API provider#3202
Open
vseehausen wants to merge 7 commits into
Open
Conversation
The /portfolio endpoint now serves Zerion data. The Zerion fallback in the balances endpoint (counterfactual safes) and the Zerion collectibles path were dead code, confirmed unused in production. Counterfactual safes now return a 404 from /balances instead of Zerion data. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
…afe check
Removing the Zerion balances provider also removed the transactionApi.isSafe(safeAddress) network call from BalancesApiManager.getApi (it only existed to branch deployed-vs-Zerion). The V1 /safes overview now makes 6 network calls instead of 7 — the duplicate GET /api/v1/safes/{address} is gone. Update the four affected assertions accordingly.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
- Drop the now-dead `safeAddress` param from `IBalancesApiManager.getApi` and every call site; remove the fake addresses generated only to satisfy it - Remove the dead `features.counterfactualBalances` flag (env var, .env.sample.json, .vscode/launch.json, config default, and the spec overrides) - Drop the redundant `rawify` in `getFiatCodes` (already returns `Raw<>`) - Add an integration test asserting a counterfactual Safe → 404 from /balances - Rename the `getApi checks` describe block to `SafeBalancesApi routing` Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…-from-balances-endpoint # Conflicts: # src/config/entities/__tests__/configuration.ts # src/config/entities/configuration.ts
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…ppers Remove the lingering FF_COUNTERFACTUAL_BALANCES export from the devcontainer compose file and collapse the now-empty testConfiguration wrappers in the balances/collectibles integration specs to pass the base configuration. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
The features override was only carrying counterfactualBalances, which was removed; the wrapper still sets mappings.safe.maxOverviews. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/portfolionow serves all Zerion data, so Zerion is no longer needed in the/balances(or/collectibles) endpoint./balancesinstead of Zerion data.ZerionBalancesApiservice, its collectibles entity/builder, and the dead integration specs.zerion-balance.entity,zerion-api.helpers, and the wallet-portfolio service, which/portfolioand/positionsstill use.Related
🤖 Generated with Claude Code