Skip to content

Handle different sequences in base event and exception event#715

Open
gharlan wants to merge 2 commits into
sabre-io:masterfrom
gharlan:recurrence-event-sequence
Open

Handle different sequences in base event and exception event#715
gharlan wants to merge 2 commits into
sabre-io:masterfrom
gharlan:recurrence-event-sequence

Conversation

@gharlan

@gharlan gharlan commented Jun 2, 2025

Copy link
Copy Markdown
Contributor

The sequence in exception events can be different to the sequence of the base event. But the ITip broker always replies with the base sequence number, even for replies to exception events.

The pull requests shows the bug.

From iCalender RFC:

Recurrence instances of a recurring component MAY have different sequence numbers.

https://datatracker.ietf.org/doc/html/rfc5545#section-3.8.7.4

Google Calendar uses different sequence numbers for exception events.
Example: Base event has sequence 2. When creating a new exception event, it gets the sequence number 3, but the base event keeps number 2.
Now when responding to the exception event via VObject iTip broker, the response contains the wrong sequence number 2, so the response is ignored by Google calender.

@codecov

codecov Bot commented May 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.77%. Comparing base (2ce84f7) to head (b4c8205).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #715   +/-   ##
=========================================
  Coverage     98.77%   98.77%           
- Complexity     1884     1885    +1     
=========================================
  Files            71       71           
  Lines          5289     5291    +2     
=========================================
+ Hits           5224     5226    +2     
  Misses           65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gharlan gharlan changed the title Test case for different sequences in base event and exception event Handle different sequences in base event and exception event May 14, 2026
@gharlan

gharlan commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

Added a fix now.

@phil-davis phil-davis force-pushed the recurrence-event-sequence branch from 8016ff4 to b4c8205 Compare May 31, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant