Skip to content

Check for string-type parameter VALUE#636

Open
martijnvankekem wants to merge 1 commit into
sabre-io:masterfrom
martijnvankekem:master
Open

Check for string-type parameter VALUE#636
martijnvankekem wants to merge 1 commit into
sabre-io:masterfrom
martijnvankekem:master

Conversation

@martijnvankekem

Copy link
Copy Markdown

See: #635

@staabm

staabm commented Jan 17, 2024

Copy link
Copy Markdown
Member

please add a test case

@codecov

codecov Bot commented Jan 17, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5df355) 98.76% compared to head (3cf6669) 98.76%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #636   +/-   ##
=========================================
  Coverage     98.76%   98.76%           
- Complexity     1866     1867    +1     
=========================================
  Files            71       71           
  Lines          5325     5325           
=========================================
  Hits           5259     5259           
  Misses           66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phil-davis

Copy link
Copy Markdown
Contributor

@martijnvankekem your PR comes directly from the master branch of your fork, which is a bit more diffcult to manage.
I rebased in a branch in my fork and made and up-to-date PR #640
The CI all passes there - good, no existing test cases were broken.

Please let us know the details of an example iCal structure - what does it pass in $parameters["VALUE"]
It will be good to add a unite test case that has a reasonably realistic example of this.

@phil-davis

Copy link
Copy Markdown
Contributor

The bit of code that is enhanced here, was removed in https://github.com/sabre-io/vobject/pull/674/changes

So there is nothing for this edit to apply to any more.

If something still needs to be changed, please advise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants