Skip to content

feat: cosmic track fitter with Acts #4281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
osbornjd merged 14 commits into from
Jun 6, 2026
Merged

feat: cosmic track fitter with Acts #4281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3b0f07b
add diagnostics
osbornjd Jun 1, 2026
1bd898e
Merge branch 'master' of github.com:sPHENIX-Collaboration/coresoftwar…
osbornjd Jun 1, 2026
8ae7512
move material selector to base object
osbornjd Jun 1, 2026
a8d3601
Fix momentum sign
osbornjd Jun 2, 2026
295065a
fix charge determination
osbornjd Jun 3, 2026
de5c39f
track fits succeed
osbornjd Jun 3, 2026
0f48224
clang-format
osbornjd Jun 3, 2026
e7ceb04
refactor into function
osbornjd Jun 3, 2026
fb23cae
refactor momentum determination into function
osbornjd Jun 3, 2026
6cb0dd2
clang-format
osbornjd Jun 3, 2026
c4441c0
fix units in diagnostic tree
osbornjd Jun 3, 2026
3891ae7
clangify cosmics trk fitter
osbornjd Jun 3, 2026
8201aee
fix benign clang tidy warning and occasional surface param problem
osbornjd Jun 4, 2026
4f61b73
trigger jenkins
osbornjd Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions offline/packages/trackbase/ActsTrackFittingAlgorithm.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,23 @@ namespace Acts
{
class TrackingGeometry;
}
struct MaterialSurfaceSelector
{
std::vector<const Acts::Surface*> surfaces = {};

/// @param surface is the test surface
void operator()(const Acts::Surface* surface)
{
if (surface->surfaceMaterial() != nullptr)
{
if (std::find(surfaces.begin(), surfaces.end(), surface) ==
surfaces.end())
{
surfaces.push_back(surface);
}
}
}
};
Comment on lines +30 to +46

@coderabbitai coderabbitai Bot Jun 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Confirm <algorithm> is not directly included and std::find is the only dependency on it.
fd -e h -e hpp 'ActsTrackFittingAlgorithm' --exec sh -c '
  echo "== {} ==";
  grep -nE "`#include` <algorithm>" "{}" || echo "NO direct <algorithm> include";
  grep -nE "std::(find|sort|count|copy|transform)\b" "{}"
'

Repository: sPHENIX-Collaboration/coresoftware

Length of output: 242

Add #include <algorithm> for std::find in MaterialSurfaceSelector

offline/packages/trackbase/ActsTrackFittingAlgorithm.h uses std::find(...) in MaterialSurfaceSelector::operator() but doesn’t include <algorithm>, so it’s relying on transitive includes.

🛠️ Proposed fix 
 `#include` <functional>
 `#include` <memory>
 `#include` <vector>
+#include <algorithm>


class ActsTrackFittingAlgorithm final
{
Expand Down
17 changes: 0 additions & 17 deletions offline/packages/trackreco/PHActsTrkFitter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,23 +295,6 @@ class PHActsTrkFitter : public SubsysReco

std::vector<const Acts::Surface*> m_materialSurfaces = {};

struct MaterialSurfaceSelector
{
std::vector<const Acts::Surface*> surfaces = {};

/// @param surface is the test surface
void operator()(const Acts::Surface* surface)
{
if (surface->surfaceMaterial() != nullptr)
{
if (std::find(surfaces.begin(), surfaces.end(), surface) ==
surfaces.end())
{
surfaces.push_back(surface);
}
}
}
};
};

#endif
Loading