Changes from Sven by vladdez · Pull Request #64 · s-ccs/ERPExplorer.jl

vladdez · 2026-04-27T12:28:06Z

add AoG for automatic style building using PlotSpec use AoG experimental backend? #58
update Makie, WGLMakie, TopoPlot
explore(...) gained new keyword options:
axis_options - labels, limits, ticks, tickformat, scale for x and y
auto_reset_view - recentering
fit_window - fitting window to viewport
Disabling linestyle if the same term is used for linestyle and row/col facet.
Creating the testing system checking each dashboard option
Dashboard testing #44 enabled

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

[JuliaFormatter] _{reported by reviewdog 🐶}

Lines 429 to 430 in f450ad3

    
           topo_widget_obs = 
        
               Observable{Any}(ERPExplorer.topoplot_widget(pos_sets[pos_keys[1]], channel_chosen; size = topo_size))

[JuliaFormatter] _{reported by reviewdog 🐶}

ERPExplorer.jl/test/serve_widgets.jl

Lines 433 to 434 in f450ad3

    
           topo_widget_obs[] = 
        
               ERPExplorer.topoplot_widget(pos_sets[key], channel_chosen; size = topo_size)

[JuliaFormatter] _{reported by reviewdog 🐶}

ERPExplorer.jl/test/serve_widgets.jl

Line 443 in f450ad3

    
           topo_widget = ERPExplorer.topoplot_widget(positions, channel_chosen; size = topo_size)

[JuliaFormatter] _{reported by reviewdog 🐶}

ERPExplorer.jl/test/serve_widgets.jl

Lines 528 to 529 in f450ad3

    
           auto_action_names = BENCH_LIVE_AUTO ? read_livebench_action_names(BENCH_LIVE_ACTIONS_FILE) : String[] 
        
           invalid_auto_actions = [n for n in auto_action_names if !haskey(available_auto_actions, n)]

[JuliaFormatter] _{reported by reviewdog 🐶}

ERPExplorer.jl/test/serve_widgets.jl

Lines 536 to 538 in f450ad3

    
           auto_actions = [ 
        
               (name, available_auto_actions[name]) for name in auto_action_names 
        
           ]

[JuliaFormatter] _{reported by reviewdog 🐶}

ERPExplorer.jl/test/serve_widgets.jl

Lines 543 to 544 in f450ad3

    
           isempty(BENCH_LIVE_REPORT) ? default_livebench_report_path(BENCH_LIVE_ACTIONS_FILE) : 
        
           BENCH_LIVE_REPORT

[JuliaFormatter] _{reported by reviewdog 🐶}

ERPExplorer.jl/test/serve_widgets.jl

Line 563 in f450ad3

println("auto-livebench action failed: ", name, " :: ", sprint(showerror, err))

[JuliaFormatter] _{reported by reviewdog 🐶}

ERPExplorer.jl/test/serve_widgets.jl

Lines 703 to 704 in f450ad3

    
           effects_value = isnothing(pending_effects_ms[]) ? NaN : pending_effects_ms[] 
        
           effects_text = isnan(effects_value) ? "n/a" : @sprintf("%.2f", effects_value)

[JuliaFormatter] _{reported by reviewdog 🐶}

ERPExplorer.jl/test/serve_widgets.jl

Lines 807 to 812 in f450ad3

    
           return DOM.div( 
        
               css, 
        
               Bonito.TailwindCSS, 
        
               cards; 
        
               style = container_style, 
        
           )

[JuliaFormatter] _{reported by reviewdog 🐶}

ERPExplorer.jl/test/serve_widgets.jl

Lines 829 to 830 in f450ad3

    
           BENCH_LIVE ? 
        
           build_live_bench_app(model; positions = positions_sets) :

[JuliaFormatter] _{reported by reviewdog 🐶}

ERPExplorer.jl/test/serve_widgets.jl

Line 833 in f450ad3

    
           println("Live bench enabled. Interact with the UI; each update prints `livebench #... total_ms=...`")

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…into SNaber-main

maybe this helps running the auto-test on github?

behinger · 2026-05-05T12:02:04Z

seems like CI / tests are running - they take ~18min

this looks correct?

vladdez · 2026-05-08T11:51:15Z

Yes, it seems correct!

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

[JuliaFormatter] _{reported by reviewdog 🐶}

ERPExplorer.jl/test/lib/live/app_builder.jl

Line 56 in 1ae32fc

yhat_dict[term] = ERPExplorer.widget_value(value_state[2], value_state[3])

[JuliaFormatter] _{reported by reviewdog 🐶}

ERPExplorer.jl/test/lib/live/app_builder.jl

Lines 82 to 83 in 1ae32fc

    
           bindings = LiveUiBindings(set_term_enabled!, set_mapping_slot!, set_channel!, reset_view!) 
        
           maybe_start_auto!() = maybe_start_auto_playback!(playback, bindings, config.live_actions_file)

[JuliaFormatter] _{reported by reviewdog 🐶}

ERPExplorer.jl/test/lib/live/app_builder.jl

Lines 140 to 141 in 1ae32fc

    
           spec = 
        
               ERPExplorer.update_grid(erp_state, formula_values, cat_terms, cont_terms, mapping_value)

[JuliaFormatter] _{reported by reviewdog 🐶}

ERPExplorer.jl/test/lib/live/auto_playback.jl

Line 336 in 1ae32fc

    
           println("auto-livebench warmup failed: ", action_id, " :: ", sprint(showerror, err))

[JuliaFormatter] _{reported by reviewdog 🐶}

ERPExplorer.jl/test/lib/live/auto_playback.jl

Line 377 in 1ae32fc

    
           println("auto-livebench action failed: ", action_id, " :: ", sprint(showerror, err))

[JuliaFormatter] _{reported by reviewdog 🐶}

ERPExplorer.jl/test/lib/live/server.jl

Line 6 in 1ae32fc

    
           function start_harness_server(app; host::AbstractString = DEFAULT_HOST, port::Int = DEFAULT_PORT)

[JuliaFormatter] _{reported by reviewdog 🐶}

ERPExplorer.jl/test/lib/live/ui_components.jl

Line 7 in 1ae32fc

    
           categorical_terms = [term for (ix, term) in enumerate(var_names) if var_types[ix] == :CategoricalTerm]

[JuliaFormatter] _{reported by reviewdog 🐶}

ERPExplorer.jl/test/lib/live/ui_components.jl

Line 27 in 1ae32fc

    
           Row(DOM.div("linestyle:"), linestyle_dd, align_items = "center", justify_items = "end"),

[JuliaFormatter] _{reported by reviewdog 🐶}

ERPExplorer.jl/test/lib/live/ui_components.jl

Line 64 in 1ae32fc

    
           topo_obs[] = ERPExplorer.topoplot_widget(pos_sets[key], channel_chosen; size = size)

[JuliaFormatter] _{reported by reviewdog 🐶}

ERPExplorer.jl/test/lib/synthetic_data.jl

Lines 17 to 20 in 1ae32fc

    
           d1 .+ 
        
           3 * sin.(0.1 * pi * i .+ Random.rand() * 2π) .+ 
        
           2 * sin.(0.3 * pi * i .* (1:n_timepoints)) .+ 
        
           Random.randn(size(d1)...) .* 5 .+

[JuliaFormatter] _{reported by reviewdog 🐶}

ERPExplorer.jl/test/lib/synthetic_data.jl

Line 39 in 1ae32fc

    
           :fruit => Random.shuffle(repeat(["orange", "banana"], outer = div(n_events, 2))),

[JuliaFormatter] _{reported by reviewdog 🐶}

ERPExplorer.jl/test/live_playback.jl

Line 80 in 1ae32fc

    
           DashboardBenchHarness.begin_auto_action!(render_timeout_state, "toggle_luminance_on", true)

[JuliaFormatter] _{reported by reviewdog 🐶}

ERPExplorer.jl/test/report_io.jl

Lines 31 to 42 in 1ae32fc

    
           [ 
        
               ( 
        
                   action_id = "baseline", 
        
                   success = true, 
        
                   runs_completed = 1, 
        
                   runs_requested = 1, 
        
                   effects_median_ms = 1.0, 
        
                   update_grid_median_ms = 2.0, 
        
                   total_median_ms = 3.0, 
        
                   error_message = "", 
        
               ), 
        
           ],

[JuliaFormatter] _{reported by reviewdog 🐶}

ERPExplorer.jl/test/report_io.jl

Lines 50 to 59 in 1ae32fc

    
           [ 
        
               ( 
        
                   sequence = 1, 
        
                   event_source = "auto:baseline", 
        
                   action_id = "baseline", 
        
                   effects_ms = 1.0, 
        
                   plot_layout_ms = 2.0, 
        
                   total_ms = 3.0, 
        
               ), 
        
           ],

github-actions · 2026-05-26T13:17:14Z

+term_type(t) = typeof(t).name.name

+is_continuous_like(term_type::Symbol) = term_type in (:ContinuousTerm, :BSplineTerm)
+is_supported_plot_term(term_type::Symbol) = term_type in (:CategoricalTerm, :ContinuousTerm, :BSplineTerm)


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

is_supported_plot_term(term_type::Symbol) = term_type in (:CategoricalTerm, :ContinuousTerm, :BSplineTerm)

is_supported_plot_term(term_type::Symbol) =

term_type in (:CategoricalTerm, :ContinuousTerm, :BSplineTerm)

github-actions · 2026-05-26T13:17:15Z

+    live_ids = Set(action_ids_for_scope(ACTION_SCOPE_LIVE))
+    bench_ids = Set(action_ids_for_scope(ACTION_SCOPE_BENCH))
+
+    default_live_ids = read_action_scenario(joinpath(@__DIR__, "livebench_actions_default.txt"))


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

default_live_ids = read_action_scenario(joinpath(@__DIR__, "livebench_actions_default.txt"))

default_live_ids =

read_action_scenario(joinpath(@__DIR__, "livebench_actions_default.txt"))

github-actions · 2026-05-26T13:17:15Z

+    @test live_cfg.live_start_delay_sec == 2.5
+    @test live_cfg.live_action_timeout_sec == 30.0
+
+    default_live_cfg = parse_harness_config(["--mode=bench-live-auto"]; script_dir = script_dir)


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

default_live_cfg = parse_harness_config(["--mode=bench-live-auto"]; script_dir = script_dir)

default_live_cfg =

parse_harness_config(["--mode=bench-live-auto"]; script_dir = script_dir)

github-actions · 2026-05-26T13:17:15Z

+const CONFIG = parse_harness_config(
+    ARGS;
+    script_dir = SCRIPT_DIR,
+)


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

const CONFIG = parse_harness_config(

ARGS;

script_dir = SCRIPT_DIR,

)

const CONFIG = parse_harness_config(ARGS; script_dir = SCRIPT_DIR)

github-actions · 2026-05-26T13:17:15Z

+       HarnessConfig,
+       MODE_HELP,
+       MODE_SERVE,
+       MODE_BENCH,
+       MODE_BENCH_LIVE_AUTO,
+       DEFAULT_HOST,
+       DEFAULT_PORT,
+       DEFAULT_SFREQ,
+       DEFAULT_BENCH_REPEATS,
+       DEFAULT_BENCH_WARMUP,
+       DEFAULT_BENCH_CHANNEL,
+       DEFAULT_LIVE_START_DELAY_SEC,
+       DEFAULT_LIVE_STEP_DELAY_SEC,
+       DEFAULT_LIVE_RENDER_SETTLE_DELAY_SEC,
+       DEFAULT_LIVE_ACTION_TIMEOUT_SEC,
+       parse_cli_args,
+       parse_harness_config,
+       usage_text,
+       action_registry,
+       registered_action_ids,
+       action_ids_for_scope,
+       live_action_triggers_render,
+       default_bench_scenario,
+       ensure_registered_action_ids,
+       read_action_scenario,
+       load_validated_scenario,
+       default_bench_report_path,
+       default_live_report_path,
+       write_bench_csv,
+       write_live_csv,
+       run_offline_benchmark,
+       build_live_benchmark_app,
+       start_harness_server,
+       build_benchmark_fixture,
+       ACTION_SCOPE_BENCH,
+       ACTION_SCOPE_LIVE


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

HarnessConfig,

MODE_HELP,

MODE_SERVE,

MODE_BENCH,

MODE_BENCH_LIVE_AUTO,

DEFAULT_HOST,

DEFAULT_PORT,

DEFAULT_SFREQ,

DEFAULT_BENCH_REPEATS,

DEFAULT_BENCH_WARMUP,

DEFAULT_BENCH_CHANNEL,

DEFAULT_LIVE_START_DELAY_SEC,

DEFAULT_LIVE_STEP_DELAY_SEC,

DEFAULT_LIVE_RENDER_SETTLE_DELAY_SEC,

DEFAULT_LIVE_ACTION_TIMEOUT_SEC,

parse_cli_args,

parse_harness_config,

usage_text,

action_registry,

registered_action_ids,

action_ids_for_scope,

live_action_triggers_render,

default_bench_scenario,

ensure_registered_action_ids,

read_action_scenario,

load_validated_scenario,

default_bench_report_path,

default_live_report_path,

write_bench_csv,

write_live_csv,

run_offline_benchmark,

build_live_benchmark_app,

start_harness_server,

build_benchmark_fixture,

ACTION_SCOPE_BENCH,

ACTION_SCOPE_LIVE

HarnessConfig,

MODE_HELP,

MODE_SERVE,

MODE_BENCH,

MODE_BENCH_LIVE_AUTO,

DEFAULT_HOST,

DEFAULT_PORT,

DEFAULT_SFREQ,

DEFAULT_BENCH_REPEATS,

DEFAULT_BENCH_WARMUP,

DEFAULT_BENCH_CHANNEL,

DEFAULT_LIVE_START_DELAY_SEC,

DEFAULT_LIVE_STEP_DELAY_SEC,

DEFAULT_LIVE_RENDER_SETTLE_DELAY_SEC,

DEFAULT_LIVE_ACTION_TIMEOUT_SEC,

parse_cli_args,

parse_harness_config,

usage_text,

action_registry,

registered_action_ids,

action_ids_for_scope,

live_action_triggers_render,

default_bench_scenario,

ensure_registered_action_ids,

read_action_scenario,

load_validated_scenario,

default_bench_report_path,

default_live_report_path,

write_bench_csv,

write_live_csv,

run_offline_benchmark,

build_live_benchmark_app,

start_harness_server,

build_benchmark_fixture,

ACTION_SCOPE_BENCH,

ACTION_SCOPE_LIVE

github-actions · 2026-05-26T13:17:16Z

+    isempty(unknown_flags) ||
+        error("Unknown flag(s): $(join("--" .* unknown_flags, ", ")). Use --help for usage.")


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

isempty(unknown_flags) ||

error("Unknown flag(s): $(join("--" .* unknown_flags, ", ")). Use --help for usage.")

isempty(unknown_flags) || error(

"Unknown flag(s): $(join("--" .* unknown_flags, ", ")). Use --help for usage.",

)

github-actions · 2026-05-26T13:17:17Z

+    bench_repeats = _parse_int(parsed.options, "bench-repeats", DEFAULT_BENCH_REPEATS; min_value = 1)
+    bench_warmup = _parse_int(parsed.options, "bench-warmup", DEFAULT_BENCH_WARMUP; min_value = 0)
+    bench_channel = _parse_int(parsed.options, "bench-channel", DEFAULT_BENCH_CHANNEL; min_value = 1)


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

bench_repeats = _parse_int(parsed.options, "bench-repeats", DEFAULT_BENCH_REPEATS; min_value = 1)

bench_warmup = _parse_int(parsed.options, "bench-warmup", DEFAULT_BENCH_WARMUP; min_value = 0)

bench_channel = _parse_int(parsed.options, "bench-channel", DEFAULT_BENCH_CHANNEL; min_value = 1)

bench_repeats =

_parse_int(parsed.options, "bench-repeats", DEFAULT_BENCH_REPEATS; min_value = 1)

bench_warmup =

_parse_int(parsed.options, "bench-warmup", DEFAULT_BENCH_WARMUP; min_value = 0)

bench_channel =

_parse_int(parsed.options, "bench-channel", DEFAULT_BENCH_CHANNEL; min_value = 1)

github-actions · 2026-05-26T13:17:17Z

+    live_action_timeout_sec <= 0.0 && error(
+        "Option --bench-live-timeout must be > 0, got $(live_action_timeout_sec).",
+    )


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

live_action_timeout_sec <= 0.0 && error(

"Option --bench-live-timeout must be > 0, got $(live_action_timeout_sec).",

)

live_action_timeout_sec <= 0.0 &&

error("Option --bench-live-timeout must be > 0, got $(live_action_timeout_sec).")

github-actions · 2026-05-26T13:17:17Z

+        default_live_report_path(config, config.live_actions_file) :
+        config.live_report_file


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

default_live_report_path(config, config.live_actions_file) :

config.live_report_file

default_live_report_path(config, config.live_actions_file) : config.live_report_file

github-actions · 2026-05-26T13:17:17Z

+        cat_terms = var_names[var_types .== :CategoricalTerm]
+        cont_terms = var_names[ERPExplorer.is_continuous_like.(var_types)]
+
+        mapping, mapping_dom, mapping_controls = build_mapping_controls(var_names, var_types)


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

mapping, mapping_dom, mapping_controls = build_mapping_controls(var_names, var_types)

mapping, mapping_dom, mapping_controls =

build_mapping_controls(var_names, var_types)

github-actions · 2026-05-26T13:28:57Z

+            for (term, value_state) in formula_state
+                if !isempty(value_state) && value_state[1] && !isempty(value_state[2])
+                    push!(active_terms, term)
+                    yhat_dict[term] = ERPExplorer.widget_value(value_state[2], value_state[3])


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

yhat_dict[term] = ERPExplorer.widget_value(value_state[2], value_state[3])

yhat_dict[term] =

ERPExplorer.widget_value(value_state[2], value_state[3])

github-actions · 2026-05-26T13:28:57Z

+        bindings = LiveUiBindings(set_term_enabled!, set_mapping_slot!, set_channel!, reset_view!)
+        maybe_start_auto!() = maybe_start_auto_playback!(playback, bindings, config.live_actions_file)


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

bindings = LiveUiBindings(set_term_enabled!, set_mapping_slot!, set_channel!, reset_view!)

maybe_start_auto!() = maybe_start_auto_playback!(playback, bindings, config.live_actions_file)

bindings =

LiveUiBindings(set_term_enabled!, set_mapping_slot!, set_channel!, reset_view!)

maybe_start_auto!() =

maybe_start_auto_playback!(playback, bindings, config.live_actions_file)

github-actions · 2026-05-26T13:28:57Z

+        try
+            apply_live_action!(bindings, action_id)
+        catch err
+            println("auto-livebench warmup failed: ", action_id, " :: ", sprint(showerror, err))


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

println("auto-livebench warmup failed: ", action_id, " :: ", sprint(showerror, err))

println(

"auto-livebench warmup failed: ",

action_id,

" :: ",

sprint(showerror, err),

)

github-actions · 2026-05-26T13:28:57Z

+            try
+                apply_live_action!(bindings, action_id)
+            catch err
+                println("auto-livebench action failed: ", action_id, " :: ", sprint(showerror, err))


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

println("auto-livebench action failed: ", action_id, " :: ", sprint(showerror, err))

println(

"auto-livebench action failed: ",

action_id,

" :: ",

sprint(showerror, err),

)

github-actions · 2026-05-26T13:28:57Z

+
+Start the Bonito server for the harness app and print the URL.
+"""
+function start_harness_server(app; host::AbstractString = DEFAULT_HOST, port::Int = DEFAULT_PORT)


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

function start_harness_server(app; host::AbstractString = DEFAULT_HOST, port::Int = DEFAULT_PORT)

function start_harness_server(

app;

host::AbstractString = DEFAULT_HOST,

port::Int = DEFAULT_PORT,

)

github-actions · 2026-05-26T13:28:58Z

+        d1 .+
+        3 * sin.(0.1 * pi * i .+ Random.rand() * 2π) .+
+        2 * sin.(0.3 * pi * i .* (1:n_timepoints)) .+
+        Random.randn(size(d1)...) .* 5 .+


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

d1 .+

3 * sin.(0.1 * pi * i .+ Random.rand() * 2π) .+

2 * sin.(0.3 * pi * i .* (1:n_timepoints)) .+

Random.randn(size(d1)...) .* 5 .+

d1 .+ 3 * sin.(0.1 * pi * i .+ Random.rand() * 2π) .+

2 * sin.(0.3 * pi * i .* (1:n_timepoints)) .+ Random.randn(size(d1)...) .* 5 .+

github-actions · 2026-05-26T13:28:58Z

+            ),
+        ),
+        :animal => Random.shuffle(repeat(["cat", "dog"], outer = div(n_events, 2))),
+        :fruit => Random.shuffle(repeat(["orange", "banana"], outer = div(n_events, 2))),


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

:fruit => Random.shuffle(repeat(["orange", "banana"], outer = div(n_events, 2))),

:fruit =>

Random.shuffle(repeat(["orange", "banana"], outer = div(n_events, 2))),

github-actions · 2026-05-26T13:28:58Z

+        ["toggle_luminance_on"],
+        joinpath(mktempdir(), "render_timeout.csv"),
+    )
+    DashboardBenchHarness.begin_auto_action!(render_timeout_state, "toggle_luminance_on", true)


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

DashboardBenchHarness.begin_auto_action!(render_timeout_state, "toggle_luminance_on", true)

DashboardBenchHarness.begin_auto_action!(

render_timeout_state,

"toggle_luminance_on",

true,

)

github-actions · 2026-05-26T13:28:58Z

+        [
+            (
+                action_id = "baseline",
+                success = true,
+                runs_completed = 1,
+                runs_requested = 1,
+                effects_median_ms = 1.0,
+                update_grid_median_ms = 2.0,
+                total_median_ms = 3.0,
+                error_message = "",
+            ),
+        ],


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

[

(

action_id = "baseline",

success = true,

runs_completed = 1,

runs_requested = 1,

effects_median_ms = 1.0,

update_grid_median_ms = 2.0,

total_median_ms = 3.0,

error_message = "",

),

],

[(

action_id = "baseline",

success = true,

runs_completed = 1,

runs_requested = 1,

effects_median_ms = 1.0,

update_grid_median_ms = 2.0,

total_median_ms = 3.0,

error_message = "",

),],

github-actions · 2026-05-26T13:28:58Z

+        [
+            (
+                sequence = 1,
+                event_source = "auto:baseline",
+                action_id = "baseline",
+                effects_ms = 1.0,
+                plot_layout_ms = 2.0,
+                total_ms = 3.0,
+            ),
+        ],


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

[

(

sequence = 1,

event_source = "auto:baseline",

action_id = "baseline",

effects_ms = 1.0,

plot_layout_ms = 2.0,

total_ms = 3.0,

),

],

[(

sequence = 1,

event_source = "auto:baseline",

action_id = "baseline",

effects_ms = 1.0,

plot_layout_ms = 2.0,

total_ms = 3.0,

),],

github-actions · 2026-06-05T13:41:13Z

+                end
+                render_count[] += 1
+                elapsed_ms = (time_ns() - t0) / 1e6
+                println("render #", render_count[], " update_grid -> layout in ", round(elapsed_ms; digits = 2), " ms")


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

println("render #", render_count[], " update_grid -> layout in ", round(elapsed_ms; digits = 2), " ms")

println(

"render #",

render_count[],

" update_grid -> layout in ",

round(elapsed_ms; digits = 2),

" ms",

)

github-actions · 2026-06-05T13:41:13Z

        res = DOM.div(
            css,
            Bonito.TailwindCSS,
            cards;
-            style = Styles(
-                "height" => "$(1.2*size[2])px",
-                "width" => "$(size[1])px",
-                "margin" => "20px",
-                "position" => :relative,
-            ),
+            style = container_style,
        )


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

res = DOM.div(

css,

Bonito.TailwindCSS,

cards;

style = Styles(

"height" => "$(1.2*size[2])px",

"width" => "$(size[1])px",

"margin" => "20px",

"position" => :relative,

),

style = container_style,

)

res = DOM.div(css, Bonito.TailwindCSS, cards; style = container_style)

github-actions · 2026-06-05T14:12:57Z

+    cat_color = get(cat_active, mapping_state[:color], false) ? mapping_state[:color] : nothing
+    cat_marker = get(cat_active, mapping_state[:marker], false) ? mapping_state[:marker] : nothing


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

cat_color = get(cat_active, mapping_state[:color], false) ? mapping_state[:color] : nothing

cat_marker = get(cat_active, mapping_state[:marker], false) ? mapping_state[:marker] : nothing

cat_color =

get(cat_active, mapping_state[:color], false) ? mapping_state[:color] : nothing

cat_marker =

get(cat_active, mapping_state[:marker], false) ? mapping_state[:marker] : nothing

github-actions · 2026-06-05T14:12:57Z

+    base = AlgebraOfGraphics.data(plot_data) *
+           AlgebraOfGraphics.mapping(:time_axis, :yhat; pairs(facet_aes)...)


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

base = AlgebraOfGraphics.data(plot_data) *

AlgebraOfGraphics.mapping(:time_axis, :yhat; pairs(facet_aes)...)

base =

AlgebraOfGraphics.data(plot_data) *

AlgebraOfGraphics.mapping(:time_axis, :yhat; pairs(facet_aes)...)

github-actions · 2026-06-05T14:12:57Z

+    scatter_layer = AlgebraOfGraphics.mapping(; pairs(scatter_aes)...) *
+                    AlgebraOfGraphics.visual(
+                        Scatter;
+                        markersize = plot_markersize,
+                        legend = (; markersize = 10.0),
+                        scatter_visual_kwargs...,
+                    )
+    line_layer = AlgebraOfGraphics.mapping(; pairs(line_aes)...) *
+                 AlgebraOfGraphics.visual(
+                     Lines;
+                     legend = (; linewidth = 1.5),
+                     line_visual_kwargs...,
+                 )


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

scatter_layer = AlgebraOfGraphics.mapping(; pairs(scatter_aes)...) *

AlgebraOfGraphics.visual(

Scatter;

markersize = plot_markersize,

legend = (; markersize = 10.0),

scatter_visual_kwargs...,

)

line_layer = AlgebraOfGraphics.mapping(; pairs(line_aes)...) *

AlgebraOfGraphics.visual(

Lines;

legend = (; linewidth = 1.5),

line_visual_kwargs...,

)

scatter_layer =

AlgebraOfGraphics.mapping(; pairs(scatter_aes)...) * AlgebraOfGraphics.visual(

Scatter;

markersize = plot_markersize,

legend = (; markersize = 10.0),

scatter_visual_kwargs...,

)

line_layer =

AlgebraOfGraphics.mapping(; pairs(line_aes)...) *

AlgebraOfGraphics.visual(Lines; legend = (; linewidth = 1.5), line_visual_kwargs...)

github-actions · 2026-06-05T14:12:57Z

+        scales_kwargs[:Marker] =
+            (;
+                palette = [:circle, :xcross, :star4, :diamond],
+                categories = categorical_levels(cat_marker),
+            )


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

scales_kwargs[:Marker] =

(;

palette = [:circle, :xcross, :star4, :diamond],

categories = categorical_levels(cat_marker),

)

scales_kwargs[:Marker] = (;

palette = [:circle, :xcross, :star4, :diamond],

categories = categorical_levels(cat_marker),

)

github-actions · 2026-06-05T14:12:57Z

+    # Translate validated axis config into kwargs consumed by AoG draw.
+    # `xlabel` falls back to x-unit dependent default when not explicitly set.
+    axis_kwargs = Dict{Symbol,Any}()
+    axis_kwargs[:xlabel] = isnothing(axis_config[:xlabel]) ? default_xlabel : axis_config[:xlabel]


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

axis_kwargs[:xlabel] = isnothing(axis_config[:xlabel]) ? default_xlabel : axis_config[:xlabel]

axis_kwargs[:xlabel] =

isnothing(axis_config[:xlabel]) ? default_xlabel : axis_config[:xlabel]

github-actions · 2026-06-05T14:12:57Z

+    axis_kwargs = Dict{Symbol,Any}()
+    axis_kwargs[:xlabel] = isnothing(axis_config[:xlabel]) ? default_xlabel : axis_config[:xlabel]
+    axis_kwargs[:ylabel] = axis_config[:ylabel]
+    for key in (:xlimits, :ylimits, :xticks, :yticks, :xtickformat, :ytickformat, :xscale, :yscale)


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

for key in (:xlimits, :ylimits, :xticks, :yticks, :xtickformat, :ytickformat, :xscale, :yscale)

for key in

(:xlimits, :ylimits, :xticks, :yticks, :xtickformat, :ytickformat, :xscale, :yscale)

github-actions · 2026-06-05T14:12:57Z

+    var_names = first.(variables)
+    categorical_terms = var_names[var_types .== :CategoricalTerm]
+    continuous_terms = var_names[ERPExplorer.is_continuous_like.(var_types)]
+    mapping = Dict(:color => :none, :marker => :none, :linestyle => :none, :col => :none, :row => :none)


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

mapping = Dict(:color => :none, :marker => :none, :linestyle => :none, :col => :none, :row => :none)

mapping = Dict(

:color => :none,

:marker => :none,

:linestyle => :none,

:col => :none,

:row => :none,

)

github-actions · 2026-06-05T14:12:58Z

+        formula_values,
+        categorical_terms,
+        continuous_terms,
+        merge(mapping, Dict(:marker => :fruit, :linestyle => :animal, :row => :fruit, :col => :animal));


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

merge(mapping, Dict(:marker => :fruit, :linestyle => :animal, :row => :fruit, :col => :animal));

merge(

mapping,

Dict(:marker => :fruit, :linestyle => :animal, :row => :fruit, :col => :animal),

);

SvenNaber and others added 4 commits February 21, 2026 23:33

AOG backend

40f6a92

Benchmarking + Bugfixes

fb629c6

gitignore/new folder reports

169ae7f

merge conflict

f450ad3

github-actions Bot reviewed Apr 27, 2026

View reviewed changes

vladdez and others added 9 commits April 27, 2026 15:12

Update src/explore.jl

fe7a399

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/explore.jl

bae2b50

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/functions_plotting.jl

65c6a57

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update test/serve_widgets.jl

7c9ea1e

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update test/serve_widgets.jl

9804bbd

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/explore.jl

5c853fb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/functions_plotting.jl

9c889e1

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

change wording

ab372e4

Update test/serve_widgets.jl

b667bf3

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

vladdez mentioned this pull request Apr 27, 2026

List of bugs 3 #65

Open

5 tasks

vladdez added 4 commits April 27, 2026 16:47

axis_options test

6e68151

Merge branch 'SNaber-main' of https://github.com/s-ccs/ERPExplorer.jl …

72b0ecb

…into SNaber-main

move gen_data to src and make it open

6f3f3fb

upgrade packages

088de54

github-actions Bot reviewed Apr 27, 2026

View reviewed changes

Comment thread src/explore.jl

vladdez and others added 7 commits April 27, 2026 18:39

rename and refactor serve_widget

652de50

Delete test/serve_widgets.jl

74e269f

bugfix

8471aa9

bugfix2

3a5817f

bugfix3

4195e1b

Delete docs/new_vs_old.md

96e58b0

add bonito.jl CI code

798a316

maybe this helps running the auto-test on github?

vladdez mentioned this pull request May 8, 2026

Tasks for Sven 08.05.26 #66

Open

16 tasks

test rework

1ae32fc

github-actions Bot reviewed May 26, 2026

View reviewed changes

fix

2c878c1

github-actions Bot reviewed May 26, 2026

View reviewed changes

Scaling lines and markers

13ffa97

github-actions Bot reviewed Jun 5, 2026

View reviewed changes

added color bar ticks

8da4ccc

github-actions Bot reviewed Jun 5, 2026

View reviewed changes

	topo_widget_obs =
	Observable{Any}(ERPExplorer.topoplot_widget(pos_sets[pos_keys[1]], channel_chosen; size = topo_size))

	topo_widget_obs[] =
	ERPExplorer.topoplot_widget(pos_sets[key], channel_chosen; size = topo_size)

	auto_action_names = BENCH_LIVE_AUTO ? read_livebench_action_names(BENCH_LIVE_ACTIONS_FILE) : String[]
	invalid_auto_actions = [n for n in auto_action_names if !haskey(available_auto_actions, n)]

	auto_actions = [
	(name, available_auto_actions[name]) for name in auto_action_names
	]

	isempty(BENCH_LIVE_REPORT) ? default_livebench_report_path(BENCH_LIVE_ACTIONS_FILE) :
	BENCH_LIVE_REPORT

	effects_value = isnothing(pending_effects_ms[]) ? NaN : pending_effects_ms[]
	effects_text = isnan(effects_value) ? "n/a" : @sprintf("%.2f", effects_value)

	return DOM.div(
	css,
	Bonito.TailwindCSS,
	cards;
	style = container_style,
	)

	BENCH_LIVE ?
	build_live_bench_app(model; positions = positions_sets) :

	bindings = LiveUiBindings(set_term_enabled!, set_mapping_slot!, set_channel!, reset_view!)
	maybe_start_auto!() = maybe_start_auto_playback!(playback, bindings, config.live_actions_file)

	spec =
	ERPExplorer.update_grid(erp_state, formula_values, cat_terms, cont_terms, mapping_value)

	d1 .+
	3 * sin.(0.1 * pi * i .+ Random.rand() * 2π) .+
	2 * sin.(0.3 * pi * i .* (1:n_timepoints)) .+
	Random.randn(size(d1)...) .* 5 .+

	[
	(
	action_id = "baseline",
	success = true,
	runs_completed = 1,
	runs_requested = 1,
	effects_median_ms = 1.0,
	update_grid_median_ms = 2.0,
	total_median_ms = 3.0,
	error_message = "",
	),
	],

	[
	(
	sequence = 1,
	event_source = "auto:baseline",
	action_id = "baseline",
	effects_ms = 1.0,
	plot_layout_ms = 2.0,
	total_ms = 3.0,
	),
	],

	is_supported_plot_term(term_type::Symbol) = term_type in (:CategoricalTerm, :ContinuousTerm, :BSplineTerm)
	is_supported_plot_term(term_type::Symbol) =
	term_type in (:CategoricalTerm, :ContinuousTerm, :BSplineTerm)

	default_live_ids = read_action_scenario(joinpath(@__DIR__, "livebench_actions_default.txt"))
	default_live_ids =
	read_action_scenario(joinpath(@__DIR__, "livebench_actions_default.txt"))

	default_live_cfg = parse_harness_config(["--mode=bench-live-auto"]; script_dir = script_dir)
	default_live_cfg =
	parse_harness_config(["--mode=bench-live-auto"]; script_dir = script_dir)

		isempty(unknown_flags) \|\|
		error("Unknown flag(s): $(join("--" .* unknown_flags, ", ")). Use --help for usage.")

		default_live_report_path(config, config.live_actions_file) :
		config.live_report_file

	mapping, mapping_dom, mapping_controls = build_mapping_controls(var_names, var_types)
	mapping, mapping_dom, mapping_controls =
	build_mapping_controls(var_names, var_types)

	yhat_dict[term] = ERPExplorer.widget_value(value_state[2], value_state[3])
	yhat_dict[term] =
	ERPExplorer.widget_value(value_state[2], value_state[3])

Conversation

vladdez commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

behinger commented May 5, 2026

Uh oh!

vladdez commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 5, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 5, 2026

vladdez commented Apr 27, 2026 •

edited

Loading

vladdez commented May 8, 2026 •

edited

Loading

	:fruit => Random.shuffle(repeat(["orange", "banana"], outer = div(n_events, 2))),
	:fruit =>
	Random.shuffle(repeat(["orange", "banana"], outer = div(n_events, 2))),

		cat_color = get(cat_active, mapping_state[:color], false) ? mapping_state[:color] : nothing
		cat_marker = get(cat_active, mapping_state[:marker], false) ? mapping_state[:marker] : nothing

		base = AlgebraOfGraphics.data(plot_data) *
		AlgebraOfGraphics.mapping(:time_axis, :yhat; pairs(facet_aes)...)

	axis_kwargs[:xlabel] = isnothing(axis_config[:xlabel]) ? default_xlabel : axis_config[:xlabel]
	axis_kwargs[:xlabel] =
	isnothing(axis_config[:xlabel]) ? default_xlabel : axis_config[:xlabel]

	for key in (:xlimits, :ylimits, :xticks, :yticks, :xtickformat, :ytickformat, :xscale, :yscale)
	for key in
	(:xlimits, :ylimits, :xticks, :yticks, :xtickformat, :ytickformat, :xscale, :yscale)