update MD_ArenaDefault current pointer in MD_ArenaDefaultPush after allocating new arena#22
Open
chitatof wants to merge 1 commit into
Open
update MD_ArenaDefault current pointer in MD_ArenaDefaultPush after allocating new arena#22chitatof wants to merge 1 commit into
chitatof wants to merge 1 commit into
Conversation
…llocating new arena
|
I'm having exactly the same confusion. I assume with this change it would be the correct behavior. The default reserve size is 64mb that's large enough that the issue don't usually occur. I took a look at raddebugger's arena impl and it's similar to this, there's indeed a line matching this change that moves the |
|
I also ran into this bug while doing some allocation-heavy workloads with this arena implementation. Applying chitatof's fix solved it for me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not familiar with this codebase, I was just looking at the arena implementation, so excuse me if this is not correct, but I believe it's intended that the "current" pointer is updated after adding a new arena to the linked list, which would be congruent with MD_ArenaDefaultPopTo behaviour.