fix: use the encoded byte count for the PDF417 byte shift - #101
Merged
hschimke merged 2 commits intoSep 16, 2026
Merged
Conversation
Collaborator
|
Thank you, reviewing and running integration now |
hschimke
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #100.
Updating the conditionals that decide whether a character can go out as a single byte is
counting characters instead of bytes. With something like
éthat's two bytes inUTF-8, only the first one gets written, and the rest of the message goes down
with it. This makes it count bytes the way ZXing does, and puts back the
bytes == null && b == 1case that goes along with it.