fix(sigv4): preserve equals in canonical uri paths#10
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc4c45a6e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
04d3b42 to
478ddd4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Thank you for your contribution, we suggest you also submit a PR to |
Signed-off-by: jianglong <jianglong@oppo.com>
478ddd4 to
a060344
Compare
|
Closing this because |
Summary
=in SigV4 canonical URI paths instead of percent-encoding it during canonical request construction$, space, and%=Related Context
rustfs/rustfs#2477https://github.com/rustfs/rustfs/pullsVerification
cargo test -p s3s canonical_request_preserves_trailing_equals_in_uri_path -- --nocapturecargo test -p s3s presigned_canonical_request_preserves_trailing_equals_in_uri_path -- --nocapturecargo test -p s3s canonical_request_still_encodes_other_reserved_uri_path_characters -- --nocapture