move validate_manifest to after remove_override_files & tweak_toml#102
Merged
Conversation
to safeguard against potential future security issues
Member
Author
emilyalbini
reviewed
Jun 20, 2025
Comment on lines
+12
to
+13
| - move manifest validation to another place in the preparation to safeguard | ||
| against potential future security issues. |
Member
There was a problem hiding this comment.
I would mention this as "security hardening".
Member
Author
There was a problem hiding this comment.
you mean as prefix? Or somehow in the sentence?
Member
There was a problem hiding this comment.
I'd probably put "move manifest validation later in the preparation to harden against possible cargo changes.". Mentioning a potential future issue implies we are aware there is going to be an issue in the future.
emilyalbini
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to safeguard against potential future security issues