break long words to prevent horizontal scroll#3384
Open
darricheng wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
S-waiting-on-review
Member
|
Fix looks good to me, thanks! Please add a GUI regression test (don't hesitate to ask if you need help). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Came across this crate with a description that was overflowing and breaking the layout:
For this specific crate description, it only breaks the layout on Safari or Chrome related browsers as Firefox breaks long words on slashes as well. A long word would break the layout on any browser, but I think that kind of case would be rarer. This CSS change breaks the word if they get too long, so that the layout doesn't break.
There's a few other CSS options that could resolve this as detailed in css-tricks, but I thought this one was the most effective and minimal change to resolve this.