Repository navigation
feat: add seed CSR - #422
Merged
Merged
Conversation
romancardenas
requested changes
Sep 30, 2026
romancardenas
left a comment
romancardenas
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution! Please, address my comment and make sure to add an entry to riscv/CHANGELOG.md to document your contribution :)
TechnoPorg
force-pushed
the
push-lvnmuszqknzv
branch
from
September 30, 2026 13:28
791b818 to
bfd7eb8
Compare
TechnoPorg
commented
Sep 30, 2026
TechnoPorg
force-pushed
the
push-lvnmuszqknzv
branch
2 times, most recently
from
September 30, 2026 14:34
c78cffd to
c69a81d
Compare
romancardenas
previously approved these changes
Oct 5, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 5, 2026
TechnoPorg
force-pushed
the
push-lvnmuszqknzv
branch
from
October 5, 2026 13:31
c69a81d to
4512b33
Compare
Contributor
Author
|
Rebased to fix changelog conflict with #423. |
romancardenas
approved these changes
Oct 5, 2026
TechnoPorg
pushed a commit
to TechnoPorg/riscv
that referenced
this pull request
Oct 5, 2026
feat: add seed CSR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is somewhat strange in that it's read-only, but requires a write instruction in order to read it, since it can have side effects in the entropy source. As such, I've manually implemented the read functions in a way that roughly mirrors the rest of the crate, but I can happily make any changes to it.
Issue #1