fix: read live test config from env vars for nightly CI#6
Merged
Conversation
Live integration tests used hardcoded API_KEY, BASE_URL, and TENANT constants that didn't match the nightly CI provisioned values, causing all Rust tests to fail with 401 KEY_NOT_FOUND since the Rust client was added. Now reads from CYCLES_API_KEY, CYCLES_BASE_URL, and CYCLES_TENANT env vars with the old values as defaults for local dev.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
API_KEY,BASE_URL, andTENANTconstants that didn't match the nightly CI provisioned values401 KEY_NOT_FOUNDsince the client was added to the nightly pipeline (Mar 31)CYCLES_API_KEY,CYCLES_BASE_URL, andCYCLES_TENANTenv vars, falling back to the old defaults for local devTest plan
cargo test --test live_server_test -- --ignoredstill works with default env