Skip to content

Update Xapian to 1.4.31 & emscripten to 3.1.74#12

Open
antoniskalou wants to merge 1 commit into
masterfrom
rage/upgrade-to-latest
Open

Update Xapian to 1.4.31 & emscripten to 3.1.74#12
antoniskalou wants to merge 1 commit into
masterfrom
rage/upgrade-to-latest

Conversation

@antoniskalou
Copy link
Copy Markdown

@antoniskalou antoniskalou commented Mar 24, 2026

This fixes the library for NodeJS version 18

@antoniskalou
Update Xapian to 1.4.31 & emscripten to 3.1.74
112212f 
This fixes the library for NodeJS version 18
@antoniskalou antoniskalou requested a review from castaway March 24, 2026 15:51
antoniskalou
antoniskalou commented Mar 24, 2026
View reviewed changes
Comment thread compilermmxapianapi.js
`-s "EXTRA_EXPORTED_RUNTIME_METHODS=['FS','cwrap','stringToUTF8','UTF8ToString','getValue']" ` +
`-std=c++11 -s DEMANGLE_SUPPORT=1 -s ALLOW_MEMORY_GROWTH=1 ` +
`-s "EXPORTED_RUNTIME_METHODS=['FS','cwrap','stringToUTF8','UTF8ToString','getValue']" ` +
`-s "EXPORTED_FUNCTIONS=['_malloc', '_free']" ` +
Copy link
Copy Markdown
Author

@antoniskalou antoniskalou Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/emscripten-core/emscripten/blob/main/ChangeLog.md#3131---012623

@antoniskalou
Copy link
Copy Markdown
Author

antoniskalou commented Mar 24, 2026 •
edited
Loading

All tests passing on local:

rage@REDACTED:~/runbox-searchindex$ node --version
v24.14.0
rage@REDACTED:~/runbox-searchindex$ npm run test-no-watch

> @runboxcom/runbox-searchindex@0.2.3 test-no-watch
> tsc -p tsconfig.json && mocha build/test/test.js



  XapianTest
Xapian loaded
Xapian runtime initialized
xapian loaded
Xapian writable database opened
    ✓ createIndex
creating 20000 messages
    ✓ createMessages
added messages 0 of 20000
added messages 500 of 20000
added messages 1000 of 20000
added messages 1500 of 20000
added messages 2000 of 20000
added messages 2500 of 20000
added messages 3000 of 20000
added messages 3500 of 20000
added messages 4000 of 20000
added messages 4500 of 20000
added messages 5000 of 20000
added messages 5500 of 20000
added messages 6000 of 20000
added messages 6500 of 20000
added messages 7000 of 20000
added messages 7500 of 20000
added messages 8000 of 20000
added messages 8500 of 20000
added messages 9000 of 20000
added messages 9500 of 20000
added messages 10000 of 20000
added messages 10500 of 20000
added messages 11000 of 20000
added messages 11500 of 20000
added messages 12000 of 20000
added messages 12500 of 20000
added messages 13000 of 20000
added messages 13500 of 20000
added messages 14000 of 20000
added messages 14500 of 20000
added messages 15000 of 20000
added messages 15500 of 20000
added messages 16000 of 20000
added messages 16500 of 20000
added messages 17000 of 20000
added messages 17500 of 20000
added messages 18000 of 20000
added messages 18500 of 20000
added messages 19000 of 20000
added messages 19500 of 20000
    ✓ addMessages (3109ms)
    ✓ hasMessageId
    ✓ getFolder
SENDER NRSK05946E74 197001011800 Q3     Sender  ÆØÅ nårsk       sender@runbox.com
SENDER NRSK05946E74 197001030000 Q8     Sender  ÆØÅ nårsk       sender@runbox.com
SENDER NRSK05946E74 197001040600 Q13    Sender  ÆØÅ nårsk       sender@runbox.com
SENDER NRSK05946E74 197001051200 Q18    Sender  ÆØÅ nårsk       sender@runbox.com
SENDER NRSK05946E74 197001061800 Q23    Sender  ÆØÅ nårsk       sender@runbox.com
SENDER NRSK05946E74 197001080000 Q28    Sender  ÆØÅ nårsk       sender@runbox.com
SENDER NRSK05946E74 197001090600 Q33    Sender  ÆØÅ nårsk       sender@runbox.com
SENDER NRSK05946E74 197001101200 Q38    Sender  ÆØÅ nårsk       sender@runbox.com
SENDER NRSK05946E74 197001111800 Q43    Sender  ÆØÅ nårsk       sender@runbox.com
SENDER NRSK05946E74 197001130000 Q48    Sender  ÆØÅ nårsk       sender@runbox.com
SENDER NRSK05946E74 197001140600 Q53    Sender  ÆØÅ nårsk       sender@runbox.com
SENDER NRSK05946E74 197001151200 Q58    Sender  ÆØÅ nårsk       sender@runbox.com
SENDER NRSK05946E74 197001161800 Q63    Sender  ÆØÅ nårsk       sender@runbox.com
SENDER NRSK05946E74 197001180000 Q68    Sender  ÆØÅ nårsk       sender@runbox.com
SENDER NRSK05946E74 197001190600 Q73    Sender  ÆØÅ nårsk       sender@runbox.com
SENDER NRSK05946E74 197001201200 Q78    Sender  ÆØÅ nårsk       sender@runbox.com
SENDER NRSK05946E74 197001211800 Q83    Sender  ÆØÅ nårsk       sender@runbox.com
SENDER NRSK05946E74 197001230000 Q88    Sender  ÆØÅ nårsk       sender@runbox.com
SENDER NRSK05946E74 197001240600 Q93    Sender  ÆØÅ nårsk       sender@runbox.com
SENDER NRSK05946E74 197001251200 Q98    Sender  ÆØÅ nårsk       sender@runbox.com
    ✓ searchMessages
moved 0 messages to Testfolder
moved 500 messages to Testfolder
    ✓ moveMessages (176ms)
1000 753 1000 753
    ✓ folderMessageCounters
Checking using sortedXapianQuery...
sortedXapianQuery runtime: 575ms (0.575ms per query)
Checking using getFolderMessageCounts...
getFolderMessageCounts runtime: 103ms (0.103ms per query)
    ✓ folderMessageCounterBenchmark (678ms)
moved 0 messages to TestChangeFolder
moved 500 messages to TestChangeFolder
    ✓ moveMessages2 (187ms)
expected number of results to delete 4000
deleted 0 messages
deleted 100 messages
deleted 200 messages
deleted 300 messages
deleted 400 messages
deleted 500 messages
deleted 600 messages
deleted 700 messages
deleted 800 messages
deleted 900 messages
deleted 1000 messages
deleted 1100 messages
deleted 1200 messages
deleted 1300 messages
deleted 1400 messages
deleted 1500 messages
deleted 1600 messages
deleted 1700 messages
deleted 1800 messages
deleted 1900 messages
deleted 2000 messages
deleted 2100 messages
deleted 2200 messages
deleted 2300 messages
deleted 2400 messages
deleted 2500 messages
deleted 2600 messages
deleted 2700 messages
deleted 2800 messages
deleted 2900 messages
deleted 3000 messages
deleted 3100 messages
deleted 3200 messages
deleted 3300 messages
deleted 3400 messages
deleted 3500 messages
deleted 3600 messages
deleted 3700 messages
deleted 3800 messages
deleted 3900 messages
    ✓ deleteMessages (141ms)
Database closed
Created compact database
    ✓ compact (124ms)
Xapian writable database opened
Xapian single file database added
Database closed
Xapian writable database opened
Searching for messages in TestFolder (from compact db)
number of documents in db before deleting from compact 16000
Try deleting messages in Testfolder (from compact db)
deleted 0 messages
deleted 100 messages
deleted 200 messages
deleted 300 messages
deleted 400 messages
deleted 500 messages
deleted 600 messages
deleted 700 messages
deleted 800 messages
deleted 900 messages
number of documents in db after deleting from compact 15000
Testfolder count 0
Database closed
    ✓ openwithcompactpartition (90ms)
Xapian writable database opened
Xapian folder database added
number of documents in db after compact 15000
Testfolder count after opening compact after delete 0
    ✓ openafterdeletefromcompactpartition
Number of flagged messages before flag 0
Number of flagged messages after flagging 1
    ✓ flagmessage
Number of flagged messages before answered flag 0
Number of flagged messages after flagging answered 1
    ✓ answeredmessage
Number of flagged messages before seen flag 740
Number of flagged messages after seen 741
    ✓ seenmessage
Number of attachment messages before seen flag 0
Number of attachment messages after attachment flag 1
    ✓ messagewithattachment

  ChangeFolderTest
xapian loaded
Xapian writable database opened
Database closed
Xapian writable database opened
Xapian folder database added
    ✓ createIndexPartitions
    ✓ searchPartitions
    ✓ changeFoldersInMainPartition
    ✓ changeFoldersInOtherPartition

  ModifyDocTermsTest
xapian loaded
Xapian writable database opened
Database closed
Xapian writable database opened
Xapian folder database added
    ✓ createIndexPartitions
    ✓ modifyTermsInMainPartition
    ✓ tryModiyTermInNonexistingDOc
Now try adding the document and changing the folder
    ✓ tryChangingFolderOfNonexistingDoc
    ✓ modifyTermsInOtherPartition
    ✓ addTextInMainPartition
    ✓ addTextInOtherPartition
    ✓ getDocumentByIdTermAndModify

  SearchTest
xapian loaded
Xapian writable database opened
added messages 0 of 99
    ✓ createIndex
[
  '"Receiver" <receiver@runbox.com>',
  '"Receiver3" <receiver3@runbox.com>',
  '"Receiver5" <receiver5@runbox.com>',
  '"U+Mq6Timrygmzwmjtjhuzdamjyga2Tcmbrhe2Tqnjxfyys4Qrxgbceemcdgnbtcrbxgyzekojfgqygo5Lon53W4Zlsonqw2Zlsnfrwcltdn5Wsm2B5Gy4Tsztcgntgmzrwmfsdiojzmu4Ggytfmqztgyrtmq4Dgntfmntcm3J5Gu2Tmmjqg44Cm4R5Mrqxm2Leeu2Da',
  'receiver7@runbox.com'
]
recipientterms [
  '"Receiver" <receiver@runbox.com>',
  '"Receiver3" <receiver3@runbox.com>',
  '"Receiver5" <receiver5@runbox.com>',
  '"U+Mq6Timrygmzwmjtjhuzdamjyga2Tcmbrhe2Tqnjxfyys4Qrxgbceemcdgnbtcrbxgyzekojfgqygo5Lon53W4Zlsonqw2Zlsnfrwcltdn5Wsm2B5Gy4Tsztcgntgmzrwmfsdiojzmu4Ggytfmqztgyrtmq4Dgntfmntcm3J5Gu2Tmmjqg44Cm4R5Mrqxm2Leeu2Da',
  'receiver7@runbox.com'
]
    ✓ searchemailaddress

  MessageInfoTest
    ✓ testGetSubjectWithoutAbbreviation
Testing that messages added to specified folders will be deleted
Deleted msg id search index 1
    ✓ testAddMessageToIndexWithDeleteFolders

  MailAddressInfoTest
    ✓ constructWithNameAndEmail
    ✓ parseSingleEmailAddress
    ✓ parseFullSingleAddress
    ✓ parseFullSingleAddressNoQuotes
    ✓ parseAddressList
    ✓ parseEmptyNamesAddress
    ✓ parseFullAddressList


  41 passing (5s)

antoniskalou
antoniskalou commented Mar 24, 2026
View reviewed changes
Comment thread compilermmxapianapi.js
execSync(`em++ -Oz -s DISABLE_EXCEPTION_CATCHING=0 -s USE_ZLIB=1 ` +
`-s "EXTRA_EXPORTED_RUNTIME_METHODS=['FS','cwrap','stringToUTF8','UTF8ToString','getValue']" ` +
`-std=c++11 -s DEMANGLE_SUPPORT=1 -s ALLOW_MEMORY_GROWTH=1 ` +
`-s "EXPORTED_RUNTIME_METHODS=['FS','cwrap','stringToUTF8','UTF8ToString','getValue']" ` +
Copy link
Copy Markdown
Author

@antoniskalou antoniskalou Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EXTRA_EXPORTED_RUNTIME_METHODS is deprecated, renamed to EXPORTED_RUNTIME_METHODS and DEMANGLE_SUPPORT is also deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@castaway castaway Awaiting requested review from castaway

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@antoniskalou