Minor bug fixes and features#47
Open
sethfaulkner wants to merge 2 commits into
Open
Conversation
added 2 commits
May 5, 2024 11:32
Owner
|
Hi! Thx for contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My team supports a private project and has run hundreds of json files through your project. It works very well for our purposes, with some minor fixes and features added. What is addressed in this pull request is:
One thing to note is that I believe there is a slight problem with the list compare logic. It will check length and that each element exists but would be defeated by the case
[1,2,2] == [1,1,2].Thanks for all the hard work on this! I hope you consider this PR.