Repository navigation
fix(runtime): keep a node first seen inside a Map or Set when it is referenced again - #693
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
evaluateraisedNoMethodError: undefined method '[]' for nilinNode#initializewhen a DOM node first appeared inside aMaporSetand was referenced again elsewhere in the same result.Chrome's deep serialization sends a shared object in full once and as a bare
weakLocalObjectReferenceafterwards.convertreturned{}formapandsetwithout reading their entries, so the full node was never recorded and the later reference reachedNode.newwith no properties.mapandsetentries are now read so their nodes are recorded; the container itself is still returned as{}.Introduced in 0.20.0 (#677), present in 0.20.1.