Repository navigation
feat(node): accept wait: in Node#click to skip waiting for a navigation - #674
Merged
Merged
Conversation
route
force-pushed
the
feat/node-click-wait
branch
from
November 4, 2026 19:08
0a9e598 to
8bd863b
Compare
Member
|
I like it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mouse#clickacceptswait:, how long to watch for a navigation started by the click, butNode#clickdoesn't, so left clicks on a node always useMouse::CLICK_WAIT. This addswait:toNode#clickwith the same default and passes it through, e.g.node.click(wait: 0)to return as soon as the click is dispatched. Right and double clicks already passwait: 0.For discussion...
My eventual goal is to thread this through Cuprite as
click(navigation_wait: 0)or similar, so a click can either skip the wait-for-navigation behavior or watch longer for a navigation that starts late (e.g. a submit handler that navigates after a fetch).