Skip to content

Fix divison#240

Closed
mrkn wants to merge 1 commit into
masterfrom
fix_div
Closed

Fix divison#240
mrkn wants to merge 1 commit into
masterfrom
fix_div

Conversation

@mrkn

@mrkn mrkn commented Nov 13, 2022

Copy link
Copy Markdown
Member

This will fix #222.

Now `BigDecimal(5) / 9` isn't correctly rounded on half down mode.
We need to fix `VpMidRound` and/or `VpLeftRound` for correct rounding.
@jeffktan

jeffktan commented May 7, 2025

Copy link
Copy Markdown

Following up on this PR as it causes slowness in our codebase. It may cause slowness many!

@mrkn

mrkn commented May 29, 2025

Copy link
Copy Markdown
Member Author

#329 fixes the problem.

@mrkn mrkn closed this May 29, 2025
@mrkn mrkn deleted the fix_div branch May 29, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exponential growth in precision causing memory usage to spike as of 3.1.2

2 participants