Repository navigation
Conversation
@material-table/core 8 drops uuid 9 for uuid 14 but needs React 19 and MUI 9, so those move with it. notistack, react-dropzone, and material-ui-confirm move to versions that support React 19, and @mui/lab is dropped since Alert is in @mui/material. Code changes for MUI 9: - Grid uses the size prop instead of item/xs/md/lg - Layout props on Grid, Stack, and Box move into sx - Typography paragraph becomes component="p" with a bottom margin - DeleteOutline is now DeleteOutlined - ListItemIcon keeps its old 56px minimum width through the theme react-dropzone now reports picked files as "./name", so the import results table strips that prefix to keep showing the plain file name.
5 tasks
MUI 9 supports Chrome 117, Edge 121 and Firefox 121 and later, so the manifests, build targets and browserslist now use those versions.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #334, so review and merge that first. GitHub will retarget this PR to
masteronce #334 merges.Clears the uuid Dependabot alert (#121). uuid 9 comes from @material-table/core 6.x. Version 8 moves to uuid 14, but it needs React 19 and depends on @mui/material ^9.2.0. The UI stack has to move with it so the app doesn't end up with two copies of MUI.
Dependency changes
Alert/AlertTitlefrom it, and those have been in @mui/material since v5.Together with #334, this also covers #329 (react-dom 18). I didn't fold in #328 (the eslint/globals/vite minor group). It's dev tooling only, isn't needed for these alerts, and can merge on its own.
After this PR,
npm audit --omit=devreports 0 vulnerabilities.Code changes
These keep the UI the same under the new APIs:
item xs={12} md={6}becomessize={{ xs: 12, md: 6 }}in the dashboard, filter views, and the unused ImportExportView.justifyContent/alignItemson Grid and Stack, andcoloron Box, move intosx. The development build logged unknown-prop warnings until this change.Stack, since MUI 9 removeddirection="column"from Grid.paragraph, so the footer usescomponent="p"withsx={{ marginBottom: 2 }}. That gives the same<p>and 16px margin.DeleteOutlineicon, so it's nowDeleteOutlined(same glyph).min-widthfrom 56px to 36px. The theme sets it back to 56px so the collapsed sidebar and the tag checklist keep their layout../name, where it used to reportname. The results table strips that prefix so it still shows the plain file name.notistack 3 still supports the
SnackbarProviderref that the Dismiss action uses. The material-table props the app uses (icons,editable,actions,components.EditRow,MTableEditRow,MTableEditField) are unchanged in v8.Checks
npm testpasses: lint (same 2 existing warnings), unit tests (2/2), Chrome/Edge/Firefox builds, manifest smoke test, zips, and web-ext lint (0 errors).innerHTMLassignments in the bundled manage chunk, coming from library code.npm lsreports no invalid peer dependencies. There's one copy each of react, @mui/material, and uuid (14.0.3)..output/chrome-mv3) and a development-mode build, so React and MUI dev warnings would show up. 14/14 checks passed on each:#/users,#/keywords, and back to#/, and a deep link to#/keywordsworks.storage.local.import-smoke.json.Risks
Manual test list
test-data/random_users1.jsonworks for this.