Repository navigation
Prepare 7.0.0: changelog, ChangeRelease, oEmbed fix, store text - #322
Merged
Merged
Conversation
Build the oEmbed request URL with URL and searchParams instead of string interpolation, so deviation URLs containing &, #, or + reach the API intact. Add a node:test unit test and run it from npm test. Fixes #295
Backfill every release from 5.0.0 through 6.2.2 from the docs site release pages (5.1.1 and 5.1.2 from their GitHub releases), and list the 7.0.0 changes under Unreleased. ChangeRelease syncs GitHub releases from the changelog. The docs Releases page now points to the changelog and GitHub Releases, and the page opened after an update is the GitHub release.
This was referenced Sep 30, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares 7.0.0. Don't merge until the owner review below is done. Once this merges, the Release PR (#241) picks it up.
Closes #300
Closes #295
Changes
CHANGELOG.mdin Keep a Changelog format, with the same header as text-utils.Unreleasedhas the 7.0.0 notes: MV3 for Chrome and Edge, Firefox stays on MV2, the WXT build, React Router 6, the Firefox data-collection declaration, the oEmbed fix, and the lodash-es and react-router-dom security updates.docs/pages/releases/*.md, with the headings mapped: New Features → Added, Bug Fixes → Fixed, Changes/Other Changes → Changed, Removed Functionality → Removed. "Release Notes" prose sits directly under the version heading. The 6.1.0<video>embed is now a link..github/workflows/changerelease.yml, copied from text-utils.dropseed/changereleaseis pinned to the v1.6.0 commit SHA, the same way the visual recap workflow pins its actions.GetOEmbedURL()inapp/scripts/background/oembed.jsbuilds the request withURLandsearchParams.set.npm testnow runstest:unit(node --test, no new dependencies). The test fails against the old string interpolation (checked by swapping it back in).rthaut.github.io/deviantART-Filter/releases/v<version>/. That docs page won't exist for 7.0.0, so the old code would have opened a 404 for everyone updating from 6.2.2 (major updates show the page by default).CHANGELOG.mdand GitHub Releases for 7.0.0 and later. The old pages stay. The 6.2.1 and 6.2.2 dates are fixed from 2023 to 2024.store/descriptions.md: draft Chrome/Edge and AMO listing text. It's plain prose with no keyword or feature lists, and it drops the stale "install from Mozilla Add-ons" and tag/category wording.Owner review
Unreleasedand the Security entries. The react-router-dom advisory (GHSA-jjmj-jmhj-qwj2) only affected 6.30.2–6.30.5. 6.2.2 shipped react-router-dom 5.3.4, so no released build was exposed. The entry says the fix is included; it doesn't claim a released version was vulnerable.CHANGELOG.mdpush and syncs the latest 5 versions (its default limit):v6.2.2tag exists now, Tag v6.2.2 #299).nextreleasecreates thev7.0.0tag and a GitHub release with an empty body when Release version 7.0.0 #241 merges. A tag pushed withGITHUB_TOKENdoesn't start other workflows, so ChangeRelease won't fill that body on its own. This matches what happened with text-utils v1.1.0 (empty release body). The suggested order:CHANGELOG.mdcommit to master that renames## [Unreleased]to## [7.0.0] - <date>, adds a new empty## [Unreleased], and updates the link references. ChangeRelease then fills in the v7.0.0 release body. You can also run the workflow manually from the Actions tab.https://github.com/rthaut/deviantART-Filter/releases/tag/v7.0.0. The release has to exist when users update, which it will once Release version 7.0.0 #241 merges.store/descriptions.md. It's used by Submit 7.0.0 to the Chrome, Edge, and Firefox stores #303.Verification
npm testpasses locally (Node 24): lint (the 2 existingno-case-declarationsdirective warnings), 2 unit tests, all three builds, manifest smoke test, zips, andweb-ext lint(0 errors, same 6 warnings as master).Unreleasedskipped, and each version's body extracts cleanly.Related 7.0.0 issues: #301 (scripted test pass), #302 (manual check), #303 (store submissions).