feat(scaffolds): add lint/i18n scaffold - #51
Conversation
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds a new lint/i18n scaffold to generate a standalone PHPCS ruleset focused on WordPress.WP.I18n, configured with the project’s text domain, and wires a composer lint:i18n script to run it.
Changes:
- Introduces a Mustache template for
phpcs.i18n.xml.distwith stricttext_domainconfiguration and sensible defaults/exclusions. - Adds
scaffold.jsonmanifest to define inputs, composer dev dependencies, and thelint:i18nscript. - Updates the wp-tooling changelog to document the new scaffold.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| node-packages/wp-tooling/scaffolds/lint/i18n/templates/phpcs.i18n.xml.dist.mustache | New standalone PHPCS ruleset template for i18n checks bound to a project text domain. |
| node-packages/wp-tooling/scaffolds/lint/i18n/scaffold.json | New scaffold manifest defining inputs, dependencies, and a lint:i18n composer script. |
| node-packages/wp-tooling/CHANGELOG.md | Documents the addition of the lint/i18n scaffold and its rationale. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
🟡 Changes recommended
Composer dev dependencies are omitted from human-readable output, and the new scaffold lacks its required Jest coverage.
Get a fresh assessment by requesting another Copilot review.
Review details
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
node-packages/wp-tooling/scaffolds/lint/i18n/scaffold.json:2
- This new scaffold has no Jest test. Repository policy requires at least one test per scaffold (CLAUDE.md:91-95); add a bundled-catalogue test that dry-runs
lint/i18nand verifies both supplied/discoveredtext_domainrendering plus the declared Composer actions.
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
* feat(scaffolds): add lint/i18n scaffold * fix(scaffolds): address Copilot review comments on lint/i18n scaffold * test(scaffolds): cover lint/i18n and fix phpcs extensions arg
Summary
Adds a
lint/i18nscaffold: a standalonephpcs.i18n.xml.distrunningWordPress.WP.I18nconfigured with the project's text domain, plus alint:i18ncomposer script. Companion tortCamp/wp-devtools's i18n lens skill (issue #45).