Fix remove command for docker volumes#1015
Merged
Merged
Conversation
* Makefile (docker-clean): Fix remove command for docker volumes.
matsl
force-pushed
the
pr_fix_docker-clean_target
branch
from
July 16, 2026 21:51
137380b to
5306767
Compare
rswgnu
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
The command was wrong. Maybe docker changed it over time but this
works on my machine.
Note
I noticed this problem when trying to develop #1007. For being close to GitHub local elpa cache have to be removed between each "make docker" run. We had a target for that but the command did not work any more and this fixes that.
With this you can do:
make docker-clean docker ...to get something close to what CI is doing in Github.
Unfortunately running without a local elpa cache does not help to trouble shoot the problem I have now. The local docker build works even without a cache even in #1007.