Promise state rewrite#116
Draft
jcheng5 wants to merge 4 commits into
Draft
Conversation
It was an attempt to shorten stack depth dramatically when used with coro async generators. I'm not sure if it worked
* main: chore(upkeep): Upkeep 2025-05 (#128) feat(future_promise): Use `future::future(..., lazy = TRUE)` to capture globals (#123) Update NEWS.md future_promise(): call future(), not sequential(), multisession(), ... (#121) Re-bump version now that docs have built Un-bump to 1.3.2; attempt to get main docs to rebuild Mention {mirai} in {future} docs (#111) Increment version number to 1.3.2.9000 Fix NEWS.md CRAN comments Increment version number to 1.3.2 Fix ever-growing call stacks
Contributor
|
(Note: in current state... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did this in a panic last night before I realized #115 was all I needed to fix https://github.com/jcheng5/shinychat/issues/16. This still might be a better design, with shorter stacks, than what's on main.