Skip to content

refactor: remove once_cell dependency#91

Open
jingyun19 wants to merge 1 commit into
rrevenantt:masterfrom
jingyun19:remove-once-cell-dep
Open

refactor: remove once_cell dependency#91
jingyun19 wants to merge 1 commit into
rrevenantt:masterfrom
jingyun19:remove-once-cell-dep

Conversation

@jingyun19

@jingyun19 jingyun19 commented Dec 17, 2025

Copy link
Copy Markdown

Remove once_cell deps now that the once_cell::sync::OnceCell functionalities are in std::sync::OnceLock

Built and tested with cargo build and cargo test.

Issue: #90

@rrevenantt

Copy link
Copy Markdown
Owner

This crate is in the process of being merged to upstream antrl4. Current work is being done in the https://github.com/antlr4rust/antlr4 so please create PR there. Eventually it will be a part of main antlr4 repository

@jingyun19

Copy link
Copy Markdown
Author

thanks for the heads up! After the merge, do we need to update the cargo in our codebase?

@rrevenantt

Copy link
Copy Markdown
Owner

You mean update dependency version in Cargo.toml? Not sure. I guess, as usual, only if you want bugfixes/improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants