refactor: remove once_cell dependency#91
Open
jingyun19 wants to merge 1 commit into
Open
Conversation
Owner
|
This crate is in the process of being merged to upstream antrl4. Current work is being done in the https://github.com/antlr4rust/antlr4 so please create PR there. Eventually it will be a part of main antlr4 repository |
Author
|
thanks for the heads up! After the merge, do we need to update the cargo in our codebase? |
Owner
|
You mean update dependency version in Cargo.toml? Not sure. I guess, as usual, only if you want bugfixes/improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove once_cell deps now that the
once_cell::sync::OnceCellfunctionalities are instd::sync::OnceLockBuilt and tested with
cargo buildandcargo test.Issue: #90