Add geff tracking format#221
Merged
Merged
Conversation
JoOkuma
reviewed
Jul 18, 2025
JoOkuma
left a comment
JoOkuma
left a comment
Member
There was a problem hiding this comment.
Hey @ilan-theodoro, it looks good and I left minor comments.
There are a lot of tests in test_geff.py, I would be ok with trimming the redundant ones, test_geff_correctness seems the most important to me.
Co-authored-by: Jordão Bragantini <jordao.bragantini@czbiohub.org>
Member
Author
|
@JoOkuma funny, that test was the only one that ai didn't write for me |
Co-authored-by: Jordão Bragantini <jordao.bragantini@czbiohub.org>
Member
|
@ilan-theodoro let's wait for the spec to be refactored, and we can revisit what changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.