Skip to content

Implement Windows autostart fix and self-update feature#105

Merged
samueltuyizere merged 6 commits into
mainfrom
92-autostart-does-not-work
Jun 28, 2026
Merged

Implement Windows autostart fix and self-update feature#105
samueltuyizere merged 6 commits into
mainfrom
92-autostart-does-not-work

Conversation

@samueltuyizere

Copy link
Copy Markdown
Collaborator
  • Added a new documentation file for the Windows autostart fix specification.
  • Enhanced the autostart functionality to handle WindowsApps aliases and improve command-line argument formatting.
  • Updated the autostart status command to check if the server process is running and log any startup errors.
  • Introduced unit tests for Windows-specific command-line building and path extraction.
  • Implemented a self-update command that allows users to check for and apply updates directly from the command line.
  • Added error handling and logging improvements during the background process startup.
  • Created a new updater package to manage downloading and verifying updates from GitHub.
  • Added tests for the updater functionality, including version comparison and checksum verification.

- Added a new documentation file for the Windows autostart fix specification.
- Enhanced the autostart functionality to handle WindowsApps aliases and improve command-line argument formatting.
- Updated the autostart status command to check if the server process is running and log any startup errors.
- Introduced unit tests for Windows-specific command-line building and path extraction.
- Implemented a self-update command that allows users to check for and apply updates directly from the command line.
- Added error handling and logging improvements during the background process startup.
- Created a new updater package to manage downloading and verifying updates from GitHub.
- Added tests for the updater functionality, including version comparison and checksum verification.
@samueltuyizere samueltuyizere linked an issue Jun 28, 2026 that may be closed by this pull request
@samueltuyizere samueltuyizere self-assigned this Jun 28, 2026
@kilo-code-bot

kilo-code-bot Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Code Review Roast 🔥

Verdict: 0 Issues Found | Recommendation: Merge

🏆 Best part: The User-Agent header now speaks proper HTTP etiquette — routatic-proxy/<version> format, just like it's supposed to. Took the feedback and ran with it.

💀 Worst part: Nothing to roast here. Both issues were fixed cleanly. The Windows backup deletion moved from ping to timeout, and the User-Agent now includes version.

📊 Overall: Like a code review where someone actually listened. The Updater package now has proper User-Agent headers and won't leave fossilized .old files when ICMP is blocked.

Files Reviewed (2 files)
  • internal/updater/updater.go - 1 issue (FIXED)
  • internal/updater/replace_windows.go - 1 issue (FIXED)
Previous Review Summary (commit dbb5095)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit dbb5095)

Verdict: 2 Issues Found | Recommendation: Address before merge

Fix these issues in Kilo Cloud

Overview

Severity Count
🚨 critical 0
⚠️ warning 1
💡 suggestion 1
Issue Details (click to expand)
File Line Roast
internal/updater/updater.go 66 User-Agent header missing version; GitHub API calls should include routatic-proxy/<version> per spec
internal/updater/replace_windows.go 20 Windows backup deletion uses ping hack; fragile and could leave .old files forever on errors

🏆 Best part: The WindowsApps alias detection in registryBinaryRef() is elegantly simple — case-insensitive path matching that just works.

💀 Worst part: The scheduleDeleteWindows function uses a ping hack for delayed deletion. This is the software equivalent of using a rubber band to fix a broken timing belt — it might work, but when it fails you've got a bigger problem.

📊 Overall: Like finding a Tesla with a cassette adapter — the core innovation is solid but some implementation details feel like they're from a different decade.

Files Reviewed (7 files)
  • internal/updater/updater.go - 1 issue
  • internal/updater/updater_test.go - clean
  • internal/updater/replace_windows.go - 1 issue
  • internal/daemon/autostart_windows.go - clean
  • internal/daemon/autostart_windows_test.go - clean
  • internal/daemon/background.go - clean
  • cmd/routatic-proxy/update.go - clean
  • cmd/routatic-proxy/main.go - clean
  • README.md - clean
  • INSTALLATION.md - clean
  • .gitignore - clean

Reviewed by laguna-m.1-20260312:free · Input: 223.9K · Output: 3.3K · Cached: 307.5K

Comment thread internal/updater/updater.go Outdated
Comment thread internal/updater/replace_windows.go Outdated
@samueltuyizere samueltuyizere merged commit f2347bd into main Jun 28, 2026
3 checks passed
@samueltuyizere samueltuyizere deleted the 92-autostart-does-not-work branch June 28, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

autostart does not work

1 participant