Skip to content

Added trigger_joint_command_threshold_enabled_ #106

Open
EnejiOhieku wants to merge 2 commits into
ros-controls:mainfrom
EnejiOhieku:trigger-joint-command-fix
Open

Added trigger_joint_command_threshold_enabled_ #106
EnejiOhieku wants to merge 2 commits into
ros-controls:mainfrom
EnejiOhieku:trigger-joint-command-fix

Conversation

@EnejiOhieku
Copy link
Copy Markdown

Added trigger_joint_command_threshold_enabled_ to ensure messages are always sent if the trigger_joint_command_threshold param is not set.

…always sent if the trigger_joint_command_threshold param is not set
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.46%. Comparing base (f496102) to head (cd26b18).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...rface/src/joint_state_topic_hardware_interface.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
- Coverage   77.89%   77.46%   -0.44%     
==========================================
  Files           6        6              
  Lines         457      457              
  Branches       46       45       -1     
==========================================
- Hits          356      354       -2     
- Misses         70       72       +2     
  Partials       31       31              
Flag Coverage Δ
unittests 77.46% <0.00%> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rface/src/joint_state_topic_hardware_interface.cpp 58.42% <0.00%> (-2.25%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@MarqRazz MarqRazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to clean this up!

@christophfroehlich christophfroehlich linked an issue Mar 24, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Member

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also be done by just changing the default value to a negative one (-1 for example), without the need of adding another member variable?

@EnejiOhieku
Copy link
Copy Markdown
Author

Yes sir. My bad 😔. I'll change it

@github-actions
Copy link
Copy Markdown
Contributor

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions Bot added the stale label May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possibility to deactivate trigger_joint_command_threshold_

4 participants