Close events/phase sidecar-value checks (+3, 106→109)#8
Merged
Conversation
The derivative-metadata family (the originally-planned next step) turned out NOT to be closeable in isolation: MISSING_RESOLUTION_DESCRIPTION / MISSING_DENSITY_DESCRIPTION don't fire even in Deno with a standalone DatasetType:derivative root + valid res-/den- filename (derivative-context detection needs more than reproduced; both validators silent, no divergence). Deferred with notes; pivoted to three clean fixture-only codes: - Add crates/bids-core/tests/misc_value_checks.rs (4 tests / 3 codes): EVENT_ONSET_ORDER (events.tsv onset not numerically sorted), PHASE_SUFFIX_DEPRECATED (func `phase` suffix), PHASE_UNITS (part-phase Units not rad/arbitrary). Confirmed 1:1 vs Deno 2.4.1. - Promote the 3 codes to RUST_CODES. ISSUE_COVERAGE.md: 106 -> 109 implemented, 72 -> 69 missing (sums to 202). - CLAUDE.md: record derivative-metadata + AGE_89 as deferred (no divergence). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…, doc sync - misc_value_checks.rs: use canonical entity order (sub-01_task-rest_part-phase_bold) for the PHASE_UNITS fixture and assert FILENAME_MISMATCH is absent; add negative controls — phase_suffix silent on a plain bold, PHASE_UNITS silent for Units rad/arbitrary. - ISSUE_COVERAGE.md: name the MRS and misc sidecar-value/TSV families (with their codes) in the crafted-fixture evidence bucket. - CLAUDE.md: replace the stale "52->202 / 126 missing" counts with a pointer to the ISSUE_COVERAGE.md status table (109 / 69). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three clean fixture-only
rules.checkscodes, basemain(not stacked):EVENT_ONSET_ORDER—events.tsvonset column not numerically sortedPHASE_SUFFIX_DEPRECATED— func files using the deprecatedphasesuffixPHASE_UNITS—part-phaseimage whoseUnitsis notrad/arbitraryAll confirmed 1:1 vs
@bids/validator2.4.1;crates/bids-core/tests/misc_value_checks.rs(4 tests, CI-gated).Deferred (documented in CLAUDE.md, no divergence)
MISSING_RESOLUTION_DESCRIPTION/MISSING_DENSITY_DESCRIPTION): would not fire even in Deno with a standaloneDatasetType:derivativeroot + validres-/den-filename — derivative-context detection needs more than reproduced (likely nesting under a raw dataset'sderivatives/). Both validators stay silent, so there's no parity divergence; needs investigation before it's closeable.AGE_89: didn't fire in either validator with a simpleparticipants.tsv.Coverage 106 → 109.
codespell/cargo fmt/clippy -D warnings/cargo test --workspacegreen; default parity sweep green; ISSUE_COVERAGE sums to 202.🤖 Generated with Claude Code