Fix coordsystem orphan parity + add schema patch layer + electrophys …#2
Merged
Merged
Conversation
…corpus Core fixes (two real parity bugs): - coordsystem.json orphan handling: replace the hardcoded EMG carve-out in SIDECAR_WITHOUT_DATAFILE with the general mechanism — build_associations now returns the fs-paths it resolved, and the caller marks them "viewed", mirroring Deno's walkBack side-effect. Orphaned coordsystem files are flagged for every modality; ones viewed by a recording's association walk are exempt. - SpoilingType: add a parse-time schema patch layer (patches.rs) supplying the missing modality/extension selectors so the warning fires once on a DWI .nii.gz instead of triplicating across .bval/.bvec. Raw schema bytes stay verbatim (build.rs static tables and --schema byte-compare unaffected); a self-test fires when upstream fixes it, and a governance test guards against patches touching statically-emitted subtrees. Tests/parity: - Add electrophysiology parity coverage (eeg_face13, ieeg_epilepsy) fetched into gitignored data/ — the gap that let the coordsystem bug through. CTF-MEG (ds000246) excluded pending .ds-bundle handling. - Promote EOG/MISC_CHANNEL_COUNT_MISMATCH into the RUST_CODES contract (Deno emits them too); update ISSUE_COVERAGE.md counts to match. - Durable regression guard is the sidecar_without_datafile unit tests. Docs: - Reflow all tracked .md files to one line per paragraph (natural pagination). - Fix YAML frontmatter break and a malformed README table cell; refresh stale build.rs/lib.rs/run.rs/test doc comments; bump status dates. - audit_response.md: durable rationale store referenced by run.py divergences. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…corpus
Core fixes (two real parity bugs):
Tests/parity:
Docs: