[Python] Release Python ownership of TCanvas registered to gROOT#22209
Open
guitargeek wants to merge 1 commit into
Open
[Python] Release Python ownership of TCanvas registered to gROOT#22209guitargeek wants to merge 1 commit into
guitargeek wants to merge 1 commit into
Conversation
Following the pattern already used for TH1/TFile/etc., drop Python ownership in the TCanvas constructor pythonization once the canvas is in `gROOT`'s list of canvases. This fixes a Jupyter kernel crash where re-running a cell that creates a TCanvas with the same name would double-delete the C++ object: The TCanvas constructor triggers deletion of the old same-name canvas, but the previous Python proxy still thought it owned the object and tried to delete it again on finalization. Close root-project#21942.
Test Results 22 files 22 suites 3d 8h 15m 43s ⏱️ For more details on these failures, see this check. Results for commit 3f29630. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the pattern already used for TH1/TFile/etc., drop Python ownership in the TCanvas constructor pythonization once the canvas is in
gROOT's list of canvases.This fixes a Jupyter kernel crash where re-running a cell that creates a TCanvas with the same name would double-delete the C++ object: The TCanvas constructor triggers deletion of the old same-name canvas, but the previous Python proxy still thought it owned the object and tried to delete it again on finalization.
Close #21942.