[df] Throw on JIT helper compilation failure instead of crashing#22206
Open
guitargeek wants to merge 1 commit into
Open
[df] Throw on JIT helper compilation failure instead of crashing#22206guitargeek wants to merge 1 commit into
guitargeek wants to merge 1 commit into
Conversation
Check the EErrorCode returned by `ProcessLine()` and verify that each helper's `DeclId_t` is non-null, throwing `std::runtime_error` in either case so users get a proper exception instead of a hard crash. Closes root-project#21659
Test Results 22 files 22 suites 3d 7h 51m 30s ⏱️ Results for commit 29aa52b. |
Member
|
I was looking into this but then I found out that for seemingly simple compilation failures cling is not able to actually report back the error to consumer code, see #22235 . I wonder how this PR is working? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the EErrorCode returned by
ProcessLine()and verify that each helper'sDeclId_tis non-null, throwingstd::runtime_errorin either case so users get a proper exception instead of a hard crash.Closes #21659
I'm going for reports related to jupyter notebooks now, which is why I tacked this issue.