Skip to content

Covers the file creation events by tests#47

Open
roma-glushko wants to merge 5 commits into
mainfrom
covered-filesystem-events-by-tests
Open

Covers the file creation events by tests#47
roma-glushko wants to merge 5 commits into
mainfrom
covered-filesystem-events-by-tests

Conversation

@roma-glushko

@roma-glushko roma-glushko commented Oct 22, 2025

Copy link
Copy Markdown
Owner
  • Covers the file creation events by tests
  • Introduced EventCollector to simplify event testing
  • Adjusted the NotifierT interface to include the stop() method

@roma-glushko roma-glushko self-assigned this Oct 22, 2025
@roma-glushko roma-glushko added the enhancement New feature or request label Oct 22, 2025
@roma-glushko roma-glushko requested a review from Copilot October 22, 2025 17:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds test coverage for file creation events and introduces infrastructure to simplify event testing. The main changes include a new EventCollector utility class for collecting and waiting on filesystem events, and updates to the NotifierT interface to support stopping the notifier.

  • Introduced EventCollector class to streamline event collection and waiting in tests
  • Added test coverage for file creation events
  • Updated NotifierT protocol to include the stop() method

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/test_events_create.py New test file that validates file creation events are properly detected and collected
tests/conftest.py Introduces EventCollector helper class for managing event collection in async tests
pytest.ini Configures pytest for async test execution
pyproject.toml Adds required test dependencies (async-timeout, pytest-asyncio)
notifykit/_notifier.py Adds stop() method to NotifierT protocol interface

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread tests/conftest.py Outdated


class EventCollector:
def __init__(self, ):

Copilot AI Oct 22, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary trailing comma and space in the __init__ parameter list. Should be def __init__(self):.

Suggested change
def __init__(self, ):
def __init__(self):

Copilot uses AI. Check for mistakes.
Roman Hlushko added 2 commits October 22, 2025 19:58

@c-h-russell-walker c-h-russell-walker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants