Covers the file creation events by tests#47
Open
roma-glushko wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds test coverage for file creation events and introduces infrastructure to simplify event testing. The main changes include a new EventCollector utility class for collecting and waiting on filesystem events, and updates to the NotifierT interface to support stopping the notifier.
- Introduced
EventCollectorclass to streamline event collection and waiting in tests - Added test coverage for file creation events
- Updated
NotifierTprotocol to include thestop()method
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_events_create.py | New test file that validates file creation events are properly detected and collected |
| tests/conftest.py | Introduces EventCollector helper class for managing event collection in async tests |
| pytest.ini | Configures pytest for async test execution |
| pyproject.toml | Adds required test dependencies (async-timeout, pytest-asyncio) |
| notifykit/_notifier.py | Adds stop() method to NotifierT protocol interface |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
|
|
||
| class EventCollector: | ||
| def __init__(self, ): |
There was a problem hiding this comment.
Remove unnecessary trailing comma and space in the __init__ parameter list. Should be def __init__(self):.
Suggested change
| def __init__(self, ): | |
| def __init__(self): |
added 2 commits
October 22, 2025 19:58
c-h-russell-walker
approved these changes
Oct 22, 2025
c-h-russell-walker
left a comment
Contributor
There was a problem hiding this comment.
Looks great 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.