Remove optional defaults from repr for SWAN#116
Draft
pbranson wants to merge 3 commits into
Draft
Conversation
Collaborator
|
That makes sense @pbranson. I normally get the INPGRID cmd from the Data classes / interfaces which construct the cmd from the swan accessor methods rather than the components - so I hadn't noticed this one. Your changes look good - but this PR also includes the changes from https://github.com/rom-py/rompy/pull/115 as well - is that intentional? |
Member
Author
|
Ah, no that was accidental and my inadequate git skills. I guess I just need to rebase to the trunk after 115 was merged? |
Collaborator
|
We could also just merge this one. I'm happy with your proposal in #115, perhaps it would be good just adding some test to demonstrate the behaviour you are implementing there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The REPR for the INPGRID command is currently including an option NHEDVEC always when this command is only relevant for vector based inputs (WIND, CURRENT). I think that when an attribute equal to the default that swan has we shouldnt write it to the REPR to prevent inadvertently introducing invalid combinations of parameters that swan doesnt like.
cc @alsonathif