Skip to content

fix: build fails if BUILD_SHARED_LIBS is set to ON when building bundled glfw #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arntanguy merged 1 commit into from
May 26, 2026
Merged

fix: build fails if BUILD_SHARED_LIBS is set to ON when building bundled glfw #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ if(NOT GLFW)
set(BUILD_STATIC
ON
CACHE BOOL "" FORCE)
set(BUILD_SHARED_LIBS
OFF
CACHE BOOL "" FORCE)
add_subdirectory(ext/glfw EXCLUDE_FROM_ALL)
else()
message(STATUS "GLFW lib found at: " ${GLFW})
Expand Down
Loading