ridecell patch

[ajinkyak423]

No description provided.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 69e0f51c-e32a-456f-83d6-0cfd43111ec0

📥 Commits

Reviewing files that changed from the base of the PR and between d53c2f4 and 2f591b8.

📒 Files selected for processing (8)

• Dockerfile
• build_local.sh
• pyproject.toml
• requirements.txt
• robusta_krr/core/integrations/kubernetes/__init__.py
• robusta_krr/core/integrations/kubernetes/config_patch.py
• robusta_krr/core/integrations/prometheus/metrics_service/prometheus_metrics_service.py
• robusta_krr/core/models/objects.py

---

Walkthrough

This PR adds Pod scanning support to KRR, updates the Kubernetes client library from v26.1.0 to v29.0.0, implements TLS server name configuration propagation through the Kubernetes client, enables PyInstaller-based binary compilation in the Docker build process, and adds debug logging for object processing.

Changes

Cohort / File(s)	Summary
Docker and Build System Dockerfile, build_local.sh	Modified Docker build to compile krr.py into a single-file PyInstaller executable, download kubectl v1.23.3 binary, and install binutils/wget. Updated local build script to target arm64 architecture and use different virtual environment path.
Kubernetes Dependency Update pyproject.toml, requirements.txt	Bumped Kubernetes Python client library version from 26.1.0 to 29.0.0 across both dependency specification files.
Pod Kind Support robusta_krr/core/models/objects.py, robusta_krr/core/integrations/prometheus/metrics_service/prometheus_metrics_service.py	Added "Pod" to KindLiteral type definitions. Implemented short-circuit logic in load_pods to handle Pod objects independently from higher-level controllers; refactored period literal computation to support hourly periods for durations ≤1 day.
Kubernetes Config TLS Support robusta_krr/core/integrations/kubernetes/config_patch.py	Extended KubeConfigLoader to read and propagate tls-server-name field from cluster configuration; added optional tls_server_name parameter to Configuration class constructor for client-side TLS configuration.
Observability Enhancements robusta_krr/core/integrations/kubernetes/__init__.py	Added COREKINDS constant listing core Kubernetes workload kinds; added debug logging to track object enumeration and filter_workflows evaluation in _list_scannable_objects.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• bug fix - krr period is 0, for period under 1 day #453: Modifies PrometheusMetricsService.load_pods period_literal computation logic to use hours for sub-day periods.
• [ROB-2447] Oomkill job fix #484: Touches the same Kubernetes integration and Prometheus metrics files, overlapping in load_pods function modifications.

Suggested reviewers

• arikalon1
• aantn

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}