Repository navigation
Tag a part set's releases by the set's name - #26
Merged
Merged
Conversation
Tags were named for the released FeatureScript's file, which FRC's and FTC's fasteners share, so FTC's release found fasteners/v1.0.0 already there and went untagged. A part set's are now named for the set (ftcFasteners/v1.0.0); FRC's set is named fasteners, so its tags keep their names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T4daFKz4qvNwCEYcg38VKS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A part set's release tag was named after the released Feature Studio's file. FRC's and FTC's fasteners share
fasteners.fs, so the FTC release foundfasteners/v1.0.0already there and went untagged.The release now names its tag after the part set (
ftcFasteners/v1.0.0). FRC's set is calledfasteners, so its tags keep their names. A new test releases two sets that share a FeatureScript and checks that each gets its own tag. It fails with the old naming.The missing
ftcFasteners/v1.0.0tag belongs on 9c51487, main's newest commit when the FTC release ran. It has to be pushed by hand:git tag -a ftcFasteners/v1.0.0 9c51487 -m "FTC Fasteners - v1.0.0" && git push origin ftcFasteners/v1.0.0.uv run pytest -q: 943 passed. Merging runs the Onshape workflow, which lands main in Onshape. No releases are pending, so it releases nothing.Generated by Claude Code