Repository navigation
Tests: clear FS_BRANCH, so the Onshape workflow's tests pass - #25
Merged
Merged
Conversation
With it set to main, the branch tests ran as if on main, and seven failed, stopping the workflow before it reached Onshape. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T4daFKz4qvNwCEYcg38VKS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Onshape workflow sets
FS_BRANCH: mainfor the whole job, sofsknows which branch it's on. The tests read that too: seven branch tests infs_cli_test.pyran as if on main and failed, which stopped the first run (from #24) before it reached Onshape. Nothing in Onshape changed.tests/conftest.pynow clearsFS_BRANCHfor every test.uv run pytest -qpasses with and withoutFS_BRANCH=mainset (942 passed).Merging this runs the Onshape workflow again: it lands main in Onshape and makes the two pending releases in
releases/.Generated by Claude Code