fix(frontend): build ladle correctly#5027
Conversation
PR ReviewWhat the PR does: Adds missing COPY of rivetkit-wasm package to all three frontend Dockerfiles (cloud, inspector, ladle) and sets SKIP_WASM_BUILD=1 to avoid invoking wasm-pack (which needs a Rust toolchain not present in these images). Assessment: Fix is correct and minimal. SKIP_WASM_BUILD is properly consumed in rivetkit-wasm/scripts/build.mjs — it checks for '1' or 'true' and exits early. Since no pre-built pkg/ artifacts are committed, the build logs 'skipped', which is fine because Vite/esbuild does not run tsc type-checking; the package just needs to be present for pnpm install to succeed. The change is applied consistently across all three Dockerfiles, SKIP_WASM_BUILD=1 is correctly placed before pnpm install, and the variable is already in turbo.json passthrough env so cache keys include it. No blocking issues. Minor notes:
Conclusion: Good, targeted fix. Safe and consistent across all three images. |
998ae2d to
3e2bff1
Compare
d1dc356 to
331cbe7
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: