Skip to content

[test] ci: pin Rust to 1.91.1/1.98.1 - #2021

Draft
eersnington wants to merge 3 commits into
mainfrom
ci/pin-rust-1-91-1
Draft

eersnington wants to merge 3 commits into
mainfrom
ci/pin-rust-1-91-1

Conversation

@eersnington

@eersnington eersnington commented Oct 4, 2026 •

Copy link
Copy Markdown
Member

checking to see if this works. not to merge.

  • Pin Rust to 1.91.1/1.98.1 for local development and native workflows.

@eersnington eersnington added the aggregate-ci Run exhaustive aggregate CI, including both WASM backends label Oct 4, 2026

@the-company-company the-company-company Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 1 medium-severity finding

Reviewed commit 37f8bf1.

Comment thread .github/workflows/ci-nightly.yml Outdated
@eersnington
eersnington marked this pull request as draft October 4, 2026 21:32
@eersnington eersnington changed the title ci: pin Rust to 1.91.1 [test] ci: pin Rust to 1.91.1/1.98.1 Oct 4, 2026
@eersnington
eersnington marked this pull request as ready for review October 4, 2026 22:22
@eersnington
eersnington changed the base branch from stack/feat-agentos-publish-default-software-list-mzsyuwnz to main October 4, 2026 22:22

@the-company-company the-company-company Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 1 medium-severity finding

Reviewed commit 7b3da38.

Comment on lines +7 to +9
const listPath = join(repoRoot, "software", "default-software.json");
const outputDir = join(packageRoot, "dist", "default-software");
const defaultSoftware = JSON.parse(readFileSync(listPath, "utf8"));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Medium · The shared default list is invisible to the Core build cache

@rivet-dev/agentos-core now derives a published dist/ artifact from software/default-software.json, but the Turbo build task hashes only src/**, tsconfig.json, and package.json (and it does not hash this scripts/ file either). After a cached Core build, changing only the shared list can therefore restore the old dist/default-software/default-software.json and package set while the release artifact publisher reads the new list directly, making the two consumers diverge. Add a Core-specific build input for this script and $TURBO_ROOT$/software/default-software.json (or make the JSON a global dependency) so list changes invalidate the staged output.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

silence

@eersnington
eersnington marked this pull request as draft October 4, 2026 22:37
@eersnington
eersnington marked this pull request as ready for review October 5, 2026 00:25
@eersnington
eersnington marked this pull request as draft October 5, 2026 00:28

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aggregate-ci Run exhaustive aggregate CI, including both WASM backends

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant