Update the Elixir requirement to ~> 1.12 - #164
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
lib/comeonin/behaviour_test_helper.ex uses stepped ranges, which were introduced in Elixir 1.12.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib/comeonin/behaviour_test_helper.exuses stepped ranges (first..last//1), which were introduced in Elixir 1.12, so~> 1.7cannot compile on 1.7 - 1.11. This makes Mix report the mismatch instead of failing later withundefined function //0.Checked at v5.5.1 plus this change: 1.11.4 gives the requirement error; 1.12.3, 1.13.4, 1.14.5, 1.15.8, 1.16.3, 1.17.3, 1.18.4 and 1.20.4 compile, and
mix test(10 tests, 0 failures) andmix format --check-formattedpass on each.The alternative is to rewrite
slices/1so that it also compiles on Elixir 1.11 and earlier; I have not done that.Fixes #163